| Message ID | 20241122-adc_ml-v1-1-0769f2e1bbc1@softing.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Support for TI ADS7128 and ADS7138 ADCs | expand |
On Fri, 22 Nov 2024 16:15:36 +0100 Tobias Sperling via B4 Relay <devnull+tobias.sperling.softing.com@kernel.org> wrote: > From: Tobias Sperling <tobias.sperling@softing.com> > > Add documentation for the driver of ADS7128 and ADS7138 12-bit, 8-channel > analog-to-digital converters. These ADCs have a wide operating range and > a wide feature set. Communication is based on the I2C interface. > > Signed-off-by: Tobias Sperling <tobias.sperling@softing.com> Hi Tobias, Welcome to IIO. This should really have been a v2 to avoid confusion but good that b4-relay worked for you. Add a little on the differences you mention below to the patch description. One comment inline. Thanks, Jonathan > --- > .../devicetree/bindings/iio/adc/ti,ads7138.yaml | 64 ++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..367d3b27cec3bc5800aac42c8a07497da7de4c1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/ti,ads7138.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments ADS7128/ADS7138 analog-to-digital converter (ADC) > + > +maintainers: > + - Tobias Sperling <tobias.sperling@softing.com> > + > +description: | > + The ADS7128 and ADS7138 chips are 12-bit, 8 channel analog-to-digital > + converters (ADC) with build-in digital window comparator (DWC), using the > + I2C interface. > + ADS7128 differs in the addition of further hardware features, like a > + root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which are > + not yet supported by the driver. Don't mention the driver in a dt-binding. It's all about the hardware not so much what we support. So say what features it has, but not the bit about support. > + > + Datasheets: > + https://www.ti.com/product/ADS7128 > + https://www.ti.com/product/ADS7138 > + > +properties: > + compatible: > + enum: > + - ti,ads7128 > + - ti,ads7138 > + > + reg: > + maxItems: 1 > + > + avdd-supply: > + description: > + The regulator used as analog supply voltage as well as reference voltage. > + > + interrupts: > + description: > + Interrupt on ALERT pin, triggers on low level. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - avdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@10 { > + compatible = "ti,ads7138"; > + reg = <0x10>; > + avdd-supply = <®_stb_3v3>; > + interrupt-parent = <&gpio2>; > + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +... >
On Fri, Nov 22, 2024 at 04:15:36PM +0100, Tobias Sperling wrote: > +description: | > + The ADS7128 and ADS7138 chips are 12-bit, 8 channel analog-to-digital > + converters (ADC) with build-in digital window comparator (DWC), using the > + I2C interface. > + ADS7128 differs in the addition of further hardware features, like a > + root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which are > + not yet supported by the driver. driver in which operating system? If FreeBSD supports them, but Linux not, are you going to udpate this text? Please drop all references to operating system and describe the hardware. With fixed description: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml new file mode 100644 index 0000000000000000000000000000000000000000..367d3b27cec3bc5800aac42c8a07497da7de4c1b --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/ti,ads7138.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments ADS7128/ADS7138 analog-to-digital converter (ADC) + +maintainers: + - Tobias Sperling <tobias.sperling@softing.com> + +description: | + The ADS7128 and ADS7138 chips are 12-bit, 8 channel analog-to-digital + converters (ADC) with build-in digital window comparator (DWC), using the + I2C interface. + ADS7128 differs in the addition of further hardware features, like a + root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which are + not yet supported by the driver. + + Datasheets: + https://www.ti.com/product/ADS7128 + https://www.ti.com/product/ADS7138 + +properties: + compatible: + enum: + - ti,ads7128 + - ti,ads7138 + + reg: + maxItems: 1 + + avdd-supply: + description: + The regulator used as analog supply voltage as well as reference voltage. + + interrupts: + description: + Interrupt on ALERT pin, triggers on low level. + maxItems: 1 + +required: + - compatible + - reg + - avdd-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + adc@10 { + compatible = "ti,ads7138"; + reg = <0x10>; + avdd-supply = <®_stb_3v3>; + interrupt-parent = <&gpio2>; + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; + }; + }; +...