| Message ID | 20241125233332.697497-1-ojeda@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/panic: remove spurious empty line to clean warning | expand |
On 26/11/2024 00:33, Miguel Ojeda wrote: > Clippy in the upcoming Rust 1.83.0 spots a spurious empty line since the > `clippy::empty_line_after_doc_comments` warning is now enabled by default > given it is part of the `suspicious` group [1]: > > error: empty line after doc comment > --> drivers/gpu/drm/drm_panic_qr.rs:931:1 > | > 931 | / /// They must remain valid for the duration of the function call. > 932 | | > | |_ > 933 | #[no_mangle] > 934 | / pub unsafe extern "C" fn drm_panic_qr_generate( > 935 | | url: *const i8, > 936 | | data: *mut u8, > 937 | | data_len: usize, > ... | > 940 | | tmp_size: usize, > 941 | | ) -> u8 { > | |_______- the comment documents this function > | > = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments > = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings` > = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]` > = help: if the empty line is unintentional remove it > > Thus remove the empty line. Thanks for this patch, it looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> > > Cc: stable@vger.kernel.org > Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") > Link: https://github.com/rust-lang/rust-clippy/pull/13091 [1] > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > --- > I added the Fixes and stable tags since it would be nice to keep the 6.12 LTS > Clippy-clean (since that one is the first that supports several Rust compilers). > > drivers/gpu/drm/drm_panic_qr.rs | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs > index 09500cddc009..ef2d490965ba 100644 > --- a/drivers/gpu/drm/drm_panic_qr.rs > +++ b/drivers/gpu/drm/drm_panic_qr.rs > @@ -929,7 +929,6 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { > /// * `tmp` must be valid for reading and writing for `tmp_size` bytes. > /// > /// They must remain valid for the duration of the function call. > - > #[no_mangle] > pub unsafe extern "C" fn drm_panic_qr_generate( > url: *const i8, > > base-commit: b7ed2b6f4e8d7f64649795e76ee9db67300de8eb > -- > 2.47.0 >
diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs index 09500cddc009..ef2d490965ba 100644 --- a/drivers/gpu/drm/drm_panic_qr.rs +++ b/drivers/gpu/drm/drm_panic_qr.rs @@ -929,7 +929,6 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { /// * `tmp` must be valid for reading and writing for `tmp_size` bytes. /// /// They must remain valid for the duration of the function call. - #[no_mangle] pub unsafe extern "C" fn drm_panic_qr_generate( url: *const i8,
Clippy in the upcoming Rust 1.83.0 spots a spurious empty line since the `clippy::empty_line_after_doc_comments` warning is now enabled by default given it is part of the `suspicious` group [1]: error: empty line after doc comment --> drivers/gpu/drm/drm_panic_qr.rs:931:1 | 931 | / /// They must remain valid for the duration of the function call. 932 | | | |_ 933 | #[no_mangle] 934 | / pub unsafe extern "C" fn drm_panic_qr_generate( 935 | | url: *const i8, 936 | | data: *mut u8, 937 | | data_len: usize, ... | 940 | | tmp_size: usize, 941 | | ) -> u8 { | |_______- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]` = help: if the empty line is unintentional remove it Thus remove the empty line. Cc: stable@vger.kernel.org Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") Link: https://github.com/rust-lang/rust-clippy/pull/13091 [1] Signed-off-by: Miguel Ojeda <ojeda@kernel.org> --- I added the Fixes and stable tags since it would be nice to keep the 6.12 LTS Clippy-clean (since that one is the first that supports several Rust compilers). drivers/gpu/drm/drm_panic_qr.rs | 1 - 1 file changed, 1 deletion(-) base-commit: b7ed2b6f4e8d7f64649795e76ee9db67300de8eb -- 2.47.0