diff mbox series

[RESEND,v4] arm64: dts: mt8183: set DMIC one-wire mode on Damu

Message ID 20241126-damu-v4-1-e746eec2cb52@chromium.org (mailing list archive)
State New
Headers show
Series [RESEND,v4] arm64: dts: mt8183: set DMIC one-wire mode on Damu | expand

Commit Message

Hsin-Te Yuan Nov. 26, 2024, 9:57 a.m. UTC 
From: Hsin-Yi Wang <hsinyi@chromium.org>

Sets DMIC one-wire mode on Damu.

Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
Changes in v4:
- Add Reviewed-by tag back, which is dropped in v3
- Link to v3: https://lore.kernel.org/r/20241009-damu-v3-1-1294c8e16829@chromium.org

Changes in v3:
- Add missing Sign-off-by tag
- Link to v2: https://lore.kernel.org/r/20240910-one-wire-v2-1-2bb40d5a3cf8@chromium.org

Changes in v2:
- Add fixes tag 
- Link to v1: https://lore.kernel.org/r/20240910-one-wire-v1-1-d25486a6ba6d@chromium.org
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 4 ++++
 1 file changed, 4 insertions(+)


---
base-commit: 7eef7e306d3c40a0c5b9ff6adc9b273cc894dbd5
change-id: 20241009-damu-a3f2f3478409

Best regards,

Comments

Krzysztof Kozlowski Nov. 26, 2024, 10:05 a.m. UTC | #1 
On 26/11/2024 10:57, Hsin-Te Yuan wrote:
> From: Hsin-Yi Wang <hsinyi@chromium.org>
> 
> Sets DMIC one-wire mode on Damu.
> 
> Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Where did this happen?

> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

And this?

> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> ---
> Changes in v4:
> - Add Reviewed-by tag back, which is dropped in v3

This resend is very weird. Didn't you get a replies that this was applied?


Best regards,
Krzysztof
Hsin-Te Yuan Nov. 26, 2024, 10:16 a.m. UTC | #2 
On Tue, Nov 26, 2024 at 6:05 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 26/11/2024 10:57, Hsin-Te Yuan wrote:
> > From: Hsin-Yi Wang <hsinyi@chromium.org>
> >
> > Sets DMIC one-wire mode on Damu.
> >
> > Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> Where did this happen?
>
https://lore.kernel.org/all/01020191db901d32-5c318445-b8f4-4f4d-86db-316dc0db04ec-000000@eu-west-1.amazonses.com/

> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> And this?
>

https://lore.kernel.org/all/5a668114-2ae6-4217-9614-b690c0870849@gmail.com/
> > Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> > ---
> > Changes in v4:
> > - Add Reviewed-by tag back, which is dropped in v3
>
> This resend is very weird. Didn't you get a replies that this was applied?
>
>
> Best regards,
> Krzysztof

This patch had been applied but was dropped due to missing a
Signed-off-by from the author
(https://lore.kernel.org/all/20241009071543.5230cf79@canb.auug.org.au/).

Regards,
Hsin-Te
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
index 65860b33c01fe832f3a4b2e21d24ea6b4f0cba2b..3935d83a047e0827b6feddceb3e4dcb4fc3407cc 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
@@ -26,6 +26,10 @@  &touchscreen {
 	hid-descr-addr = <0x0001>;
 };
 
+&mt6358codec {
+	mediatek,dmic-mode = <1>; /* one-wire */
+};
+
 &qca_wifi {
 	qcom,ath10k-calibration-variant = "GO_DAMU";
 };