| Message ID | 20241126102311.344972-1-przemyslaw.korba@intel.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [iwl-net] ice: fix incorrect PHY settings for 100 GB/s | expand |
Dear Przemyslaw, Thank you for your patch. Am 26.11.24 um 11:23 schrieb Przemyslaw Korba: > ptp4l application reports too high offset when ran on E823 device > with a 100GB/s link. Those values cannot go under 100ns, like in a > PTP working case when using 100 GB/s cable. > This is due to incorrect frequency settings on the PHY clocks for > 100 GB/s speed. Changes are introduced to align with the internal > hardware documentation, and correctly initialize frequency in PHY It’d be great if you added the documentation name. > clocks with the frequency values that are in our HW spec. > To reproduce the issue run ptp4l as a Time Receiver on E823 device, > and observe the offset, which will never approach values seen > in the PTP working case. (I’d add a blank line between paragraphs.) Also, I always like to see pastes from the commands you ran to reproduce this. It’s always good for comparison. > Fixes: 3a7496234d17 ("ice: implement basic E822 PTP support") Any idea, where the wrong values came from? Will your test be added to the test procedure? > Reviewed-by: Milena Olech <milena.olech@intel.com> > Signed-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com> > --- > drivers/net/ethernet/intel/ice/ice_ptp_consts.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_consts.h b/drivers/net/ethernet/intel/ice/ice_ptp_consts.h > index 6620642077bb..bdb1020147d1 100644 > --- a/drivers/net/ethernet/intel/ice/ice_ptp_consts.h > +++ b/drivers/net/ethernet/intel/ice/ice_ptp_consts.h > @@ -761,9 +761,9 @@ const struct ice_vernier_info_e82x e822_vernier[NUM_ICE_PTP_LNK_SPD] = { > /* rx_desk_rsgb_par */ > 644531250, /* 644.53125 MHz Reed Solomon gearbox */ > /* tx_desk_rsgb_pcs */ > - 644531250, /* 644.53125 MHz Reed Solomon gearbox */ > + 390625000, /* 390.625 MHz Reed Solomon gearbox */ > /* rx_desk_rsgb_pcs */ > - 644531250, /* 644.53125 MHz Reed Solomon gearbox */ > + 390625000, /* 390.625 MHz Reed Solomon gearbox */ > /* tx_fixed_delay */ > 1620, > /* pmd_adj_divisor */ Kind regards, Paul
On Tue, Nov 26, 2024 at 11:23:11AM +0100, Przemyslaw Korba wrote: > ptp4l application reports too high offset when ran on E823 device > with a 100GB/s link. Those values cannot go under 100ns, like in a > PTP working case when using 100 GB/s cable. > This is due to incorrect frequency settings on the PHY clocks for > 100 GB/s speed. Changes are introduced to align with the internal > hardware documentation, and correctly initialize frequency in PHY > clocks with the frequency values that are in our HW spec. > To reproduce the issue run ptp4l as a Time Receiver on E823 device, > and observe the offset, which will never approach values seen > in the PTP working case. You forgot to Cc: the PTP maintainer. If i spent the time to measure the latency and configured ptp4l correctly to take into account the latency, would i not see this issue? And will this change then cause a regression because it changes the latency invalidating my measurements? Andrew
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_consts.h b/drivers/net/ethernet/intel/ice/ice_ptp_consts.h index 6620642077bb..bdb1020147d1 100644 --- a/drivers/net/ethernet/intel/ice/ice_ptp_consts.h +++ b/drivers/net/ethernet/intel/ice/ice_ptp_consts.h @@ -761,9 +761,9 @@ const struct ice_vernier_info_e82x e822_vernier[NUM_ICE_PTP_LNK_SPD] = { /* rx_desk_rsgb_par */ 644531250, /* 644.53125 MHz Reed Solomon gearbox */ /* tx_desk_rsgb_pcs */ - 644531250, /* 644.53125 MHz Reed Solomon gearbox */ + 390625000, /* 390.625 MHz Reed Solomon gearbox */ /* rx_desk_rsgb_pcs */ - 644531250, /* 644.53125 MHz Reed Solomon gearbox */ + 390625000, /* 390.625 MHz Reed Solomon gearbox */ /* tx_fixed_delay */ 1620, /* pmd_adj_divisor */
ptp4l application reports too high offset when ran on E823 device with a 100GB/s link. Those values cannot go under 100ns, like in a PTP working case when using 100 GB/s cable. This is due to incorrect frequency settings on the PHY clocks for 100 GB/s speed. Changes are introduced to align with the internal hardware documentation, and correctly initialize frequency in PHY clocks with the frequency values that are in our HW spec. To reproduce the issue run ptp4l as a Time Receiver on E823 device, and observe the offset, which will never approach values seen in the PTP working case. Fixes: 3a7496234d17 ("ice: implement basic E822 PTP support") Reviewed-by: Milena Olech <milena.olech@intel.com> Signed-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com> --- drivers/net/ethernet/intel/ice/ice_ptp_consts.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 6ef5f61a4aa7d4df94a855a44f996bff08b0be83