| Message ID | 20241127-gs101-phy-lanes-orientation-phy-v1-2-1b7fce24960b@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | USB31DRD phy updates for Google Tensor gs101 (orientation & DWC3 rpm) | expand |
On Wed, Nov 27, 2024 at 10:58:12AM +0000, André Draszik wrote: > orientation-switch is the standard declaration to inform the Type-C mux > layer that a remote-endpoint is capable of processing orientation > change messages. > > Add as an optional since not all versions of this phy currently support > or even need the orientation-switch. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Wed, Nov 27, 2024 at 04:00:59PM +0000, Conor Dooley wrote: > On Wed, Nov 27, 2024 at 10:58:12AM +0000, André Draszik wrote: > > orientation-switch is the standard declaration to inform the Type-C mux > > layer that a remote-endpoint is capable of processing orientation > > change messages. > > > > Add as an optional since not all versions of this phy currently support > > or even need the orientation-switch. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Actually, this patch unconditionally adds the property to the binding. Is it valid for !gs101?
Hi Conor, Thanks for your review. On Wed, 2024-11-27 at 16:02 +0000, Conor Dooley wrote: > On Wed, Nov 27, 2024 at 04:00:59PM +0000, Conor Dooley wrote: > > On Wed, Nov 27, 2024 at 10:58:12AM +0000, André Draszik wrote: > > > orientation-switch is the standard declaration to inform the Type-C > > > mux > > > layer that a remote-endpoint is capable of processing orientation > > > change messages. > > > > > > Add as an optional since not all versions of this phy currently > > > support > > > or even need the orientation-switch. > > > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Actually, this patch unconditionally adds the property to the binding. > Is it valid for !gs101? Good point. I've only made it required for gs101 in the next patch, but as- is, somebody could still add it (in error) in !gs101 cases. I guess it's best to squash patches 3 and 4 in that case, and update it to disallow for !gs101. Thanks, Andre'
On Wed, Nov 27, 2024 at 04:27:09PM +0000, André Draszik wrote: > Hi Conor, > > Thanks for your review. > > On Wed, 2024-11-27 at 16:02 +0000, Conor Dooley wrote: > > On Wed, Nov 27, 2024 at 04:00:59PM +0000, Conor Dooley wrote: > > > On Wed, Nov 27, 2024 at 10:58:12AM +0000, André Draszik wrote: > > > > orientation-switch is the standard declaration to inform the Type-C > > > > mux > > > > layer that a remote-endpoint is capable of processing orientation > > > > change messages. > > > > > > > > Add as an optional since not all versions of this phy currently > > > > support > > > > or even need the orientation-switch. > > > > > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > Actually, this patch unconditionally adds the property to the binding. > > Is it valid for !gs101? > > Good point. I've only made it required for gs101 in the next patch, but as- > is, somebody could still add it (in error) in !gs101 cases. > I guess it's best to squash patches 3 and 4 in that case, and update it to > disallow for !gs101. SGTM, go ahead.
diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml index 1f8b35917b11..6c17a44718aa 100644 --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml @@ -51,6 +51,9 @@ properties: "#phy-cells": const: 1 + orientation-switch: + $ref: /schemas/usb/usb-switch.yaml#/properties/orientation-switch + port: $ref: /schemas/graph.yaml#/properties/port description:
orientation-switch is the standard declaration to inform the Type-C mux layer that a remote-endpoint is capable of processing orientation change messages. Add as an optional since not all versions of this phy currently support or even need the orientation-switch. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml | 3 +++ 1 file changed, 3 insertions(+)