mbox series

[v4,0/2] power: supply: Add STC3117 Fuel Gauge

Message ID 20241127151953.29550-1-bhavin.sharma@siliconsignals.io (mailing list archive)
Headers show
Series power: supply: Add STC3117 Fuel Gauge | expand

Message

Bhavin Sharma Nov. 27, 2024, 3:19 p.m. UTC 
From: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>

Adds initial support for the STC3117 fuel gauge.

v3 -> v4

- Added support for current, soc, temp, and status properties.
- Addressed comments and feedback provided by Krzysztof and Sebastian.
 
Link for v3: https://lore.kernel.org/linux-pm/20240205051321.4079933-1-bhavin.sharma@siliconsignals.io/T/#t

v2 -> v3

- Resolved DTC warnings and errors
- Formatted the changelogs
- Added monitored battery properties
- Replaced 'additionalProperties' with 'unevaluatedProperties'
- Replaced '&i2c6' with 'i2c'

Link for v2: https://lore.kernel.org/linux-pm/202401080530.0hMWnrIg-lkp@intel.com/T/#t

v1 -> v2

- String value is redundantly quoted with any quotes (quoted-strings)
- Found character '\t' that cannot start any token

Link for v1: https://lore.kernel.org/linux-pm/46bba29c-330d-417d-ad84-ceb5207fdb55@wanadoo.fr/T/#t

Hardevsinh Palaniya(1):
  dt-bindings: power: supply: Add STC3117 Fuel Gauge

Bhavin Sharma(2):
  power: supply: Add STC3117 fuel gauge unit driver

 .../bindings/power/supply/st,stc3117.yaml     |  53 ++
 MAINTAINERS                                   |   8 +
 drivers/power/supply/Kconfig                  |   7 +
 drivers/power/supply/Makefile                 |   1 +
 drivers/power/supply/stc3117_fuel_gauge.c     | 625 ++++++++++++++++++
 5 files changed, 694 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/st,stc3117.yaml
 create mode 100644 drivers/power/supply/stc3117_fuel_gauge.c

Comments

Krzysztof Kozlowski Nov. 27, 2024, 6:18 p.m. UTC | #1 
On 27/11/2024 16:19, Bhavin Sharma wrote:
> From: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
> 
> Adds initial support for the STC3117 fuel gauge.
> 
> v3 -> v4
> 
> - Added support for current, soc, temp, and status properties.
> - Addressed comments and feedback provided by Krzysztof and Sebastian.

Which comments? What changed exactly? This has to be precise.

Best regards,
Krzysztof