| Message ID | 20241127015224.2361-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: rename rfkill label for Radxa ROCK 5B | expand |
Hello Fukaumi, On 2024-11-27 02:52, FUKAUMI Naoki wrote: > on ROCK 5B, there is no PCIe slot, instead there is a M.2 slot. > rfkill pin is not exclusive to PCIe devices, there is SDIO Wi-Fi > devices. > > rename rfkill label from "rfkill-pcie-wlan" to "rfkill-m2-wlan", it > matches with rfkill-bt. > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> Thanks for this patch, renaming the rfkill label this way makes sense to me. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > index c44d001da169..d597112f1d5b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -72,7 +72,7 @@ fan: pwm-fan { > > rfkill { > compatible = "rfkill-gpio"; > - label = "rfkill-pcie-wlan"; > + label = "rfkill-m2-wlan"; > radio-type = "wlan"; > shutdown-gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>; > };
Hi, I forgot one thing... On 11/27/24 10:52, FUKAUMI Naoki wrote: > on ROCK 5B, there is no PCIe slot, instead there is a M.2 slot. > rfkill pin is not exclusive to PCIe devices, there is SDIO Wi-Fi > devices. > > rename rfkill label from "rfkill-pcie-wlan" to "rfkill-m2-wlan", it > matches with rfkill-bt. > Fixes: 82d40b141a4c ("arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b") -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > index c44d001da169..d597112f1d5b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -72,7 +72,7 @@ fan: pwm-fan { > > rfkill { > compatible = "rfkill-gpio"; > - label = "rfkill-pcie-wlan"; > + label = "rfkill-m2-wlan"; > radio-type = "wlan"; > shutdown-gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>; > };
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index c44d001da169..d597112f1d5b 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -72,7 +72,7 @@ fan: pwm-fan { rfkill { compatible = "rfkill-gpio"; - label = "rfkill-pcie-wlan"; + label = "rfkill-m2-wlan"; radio-type = "wlan"; shutdown-gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>; };
on ROCK 5B, there is no PCIe slot, instead there is a M.2 slot. rfkill pin is not exclusive to PCIe devices, there is SDIO Wi-Fi devices. rename rfkill label from "rfkill-pcie-wlan" to "rfkill-m2-wlan", it matches with rfkill-bt. Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)