| Message ID | 20241128120922.3518582-3-quic_chejiang@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | bluetooth: qca: Add QCA6698 Bluetooth chip | expand |
On Thu, Nov 28, 2024 at 08:09:21PM +0800, Cheng Jiang wrote: > Add the compatible for the Bluetooth part of the Qualcomm QCA6698 chipset. ... And you have misssed to explain why do you need to add it and how it is different from WCN6855. > > Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> > --- > .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > index 7bb68311c..82105382a 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > @@ -18,6 +18,7 @@ properties: > enum: > - qcom,qca2066-bt > - qcom,qca6174-bt > + - qcom,qca6698-bt > - qcom,qca9377-bt > - qcom,wcn3988-bt > - qcom,wcn3990-bt > @@ -170,6 +171,7 @@ allOf: > contains: > enum: > - qcom,wcn6855-bt > + - qcom,qca6698-bt > then: > required: > - vddrfacmn-supply > -- > 2.25.1 >
On 28/11/2024 13:09, Cheng Jiang wrote:
> Add the compatible for the Bluetooth part of the Qualcomm QCA6698 chipset.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Respond to the comment and then implement it.
Also, version your patches correct and provide changelog. This is v2,
not v1.
Best regards,
Krzysztof
On 28/11/2024 15:41, Krzysztof Kozlowski wrote: > On 28/11/2024 13:09, Cheng Jiang wrote: >> Add the compatible for the Bluetooth part of the Qualcomm QCA6698 chipset. > > <form letter> > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. > </form letter> > > Respond to the comment and then implement it. > > Also, version your patches correct and provide changelog. This is v2, > not v1. Wait, no, it's even v3 or v4. You just ask us to the same work twice, don't you? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index 7bb68311c..82105382a 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -18,6 +18,7 @@ properties: enum: - qcom,qca2066-bt - qcom,qca6174-bt + - qcom,qca6698-bt - qcom,qca9377-bt - qcom,wcn3988-bt - qcom,wcn3990-bt @@ -170,6 +171,7 @@ allOf: contains: enum: - qcom,wcn6855-bt + - qcom,qca6698-bt then: required: - vddrfacmn-supply
Add the compatible for the Bluetooth part of the Qualcomm QCA6698 chipset. Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> --- .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ 1 file changed, 2 insertions(+)