| Message ID | 20241129095507.11001-1-lorenzo.stoakes@oracle.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [man-pages] process_madvise.2: describe 6.13 behaviour permitting all madvise flags | expand |
On 29.11.24 10:55, Lorenzo Stoakes wrote: > Since Linux 6.13 it has become possible to use all madvise flags when targeting > the calling process. Update the man page to reflect this change. > > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> > --- > man/man2/process_madvise.2 | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/man/man2/process_madvise.2 b/man/man2/process_madvise.2 > index b78a61553..d12407bdb 100644 > --- a/man/man2/process_madvise.2 > +++ b/man/man2/process_madvise.2 > @@ -54,7 +54,7 @@ This value must be less than or equal to > or accessible via the call > .IR sysconf(_SC_IOV_MAX) ). > .P > -The > +If manipulating another process, or prior to Linux 6.13, the > .I advice > argument is one of the following values: > .TP > @@ -74,6 +74,9 @@ See > See > .BR madvise (2). > .P > +Starting in Linux 6.13, when manipulating the calling process, any advice flag > +is permitted. > +.P > The > .I flags > argument is reserved for future use; currently, this argument must be I was briefly concerned when reading the subject, then I realized here "calling process" :) Reviewed-by: David Hildenbrand <david@redhat.com>
On Fri, Nov 29, 2024 at 01:14:08PM +0100, David Hildenbrand wrote: > On 29.11.24 10:55, Lorenzo Stoakes wrote: > > Since Linux 6.13 it has become possible to use all madvise flags when targeting > > the calling process. Update the man page to reflect this change. > > > > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> > > --- > > man/man2/process_madvise.2 | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/man/man2/process_madvise.2 b/man/man2/process_madvise.2 > > index b78a61553..d12407bdb 100644 > > --- a/man/man2/process_madvise.2 > > +++ b/man/man2/process_madvise.2 > > @@ -54,7 +54,7 @@ This value must be less than or equal to > > or accessible via the call > > .IR sysconf(_SC_IOV_MAX) ). > > .P > > -The > > +If manipulating another process, or prior to Linux 6.13, the > > .I advice > > argument is one of the following values: > > .TP > > @@ -74,6 +74,9 @@ See > > See > > .BR madvise (2). > > .P > > +Starting in Linux 6.13, when manipulating the calling process, any advice flag > > +is permitted. > > +.P > > The > > .I flags > > argument is reserved for future use; currently, this argument must be > > I was briefly concerned when reading the subject, then I realized here > "calling process" :) Haha yes, I did wonder how that would sound when I wrote it, but sort of ran out of space in the subject and hoped the commit message would reduce panic :P > > Reviewed-by: David Hildenbrand <david@redhat.com> Thanks! > > -- > Cheers, > > David / dhildenb >
Hi Lorenzo, On Fri, Nov 29, 2024 at 09:55:07AM +0000, Lorenzo Stoakes wrote: > Since Linux 6.13 it has become possible to use all madvise flags when targeting > the calling process. Update the man page to reflect this change. > > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> > --- > man/man2/process_madvise.2 | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/man/man2/process_madvise.2 b/man/man2/process_madvise.2 > index b78a61553..d12407bdb 100644 > --- a/man/man2/process_madvise.2 > +++ b/man/man2/process_madvise.2 > @@ -54,7 +54,7 @@ This value must be less than or equal to > or accessible via the call > .IR sysconf(_SC_IOV_MAX) ). > .P > -The > +If manipulating another process, or prior to Linux 6.13, the For consistency with other pages, how s/prior to/before/? Prior to is ok; it's just for being able to grep for a single expression. > .I advice > argument is one of the following values: > .TP > @@ -74,6 +74,9 @@ See > See > .BR madvise (2). > .P > +Starting in Linux 6.13, when manipulating the calling process, any advice flag > +is permitted. Please use semantic newlines. See man-pages(7), and the other email. Cheers, Alex > +.P > The > .I flags > argument is reserved for future use; currently, this argument must be > -- > 2.47.1
On Fri, Nov 29, 2024 at 01:37:41PM +0100, Alejandro Colomar wrote: > Hi Lorenzo, > > On Fri, Nov 29, 2024 at 09:55:07AM +0000, Lorenzo Stoakes wrote: > > Since Linux 6.13 it has become possible to use all madvise flags when targeting > > the calling process. Update the man page to reflect this change. > > > > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> > > --- > > man/man2/process_madvise.2 | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/man/man2/process_madvise.2 b/man/man2/process_madvise.2 > > index b78a61553..d12407bdb 100644 > > --- a/man/man2/process_madvise.2 > > +++ b/man/man2/process_madvise.2 > > @@ -54,7 +54,7 @@ This value must be less than or equal to > > or accessible via the call > > .IR sysconf(_SC_IOV_MAX) ). > > .P > > -The > > +If manipulating another process, or prior to Linux 6.13, the > > For consistency with other pages, how s/prior to/before/? Prior to is > ok; it's just for being able to grep for a single expression. Ah, I think I saw a 'prior to' somewhere but actually no, that was the 'starting in' below, my mistake. Will fix up! > > > .I advice > > argument is one of the following values: > > .TP > > @@ -74,6 +74,9 @@ See > > See > > .BR madvise (2). > > .P > > +Starting in Linux 6.13, when manipulating the calling process, any advice flag > > +is permitted. > > Please use semantic newlines. See man-pages(7), and the other email. Ack, will do! > > Cheers, > Alex > > > +.P > > The > > .I flags > > argument is reserved for future use; currently, this argument must be > > -- > > 2.47.1 > > -- > <https://www.alejandro-colomar.es/> Will respin and send a v2 shortly. Thanks!
diff --git a/man/man2/process_madvise.2 b/man/man2/process_madvise.2 index b78a61553..d12407bdb 100644 --- a/man/man2/process_madvise.2 +++ b/man/man2/process_madvise.2 @@ -54,7 +54,7 @@ This value must be less than or equal to or accessible via the call .IR sysconf(_SC_IOV_MAX) ). .P -The +If manipulating another process, or prior to Linux 6.13, the .I advice argument is one of the following values: .TP @@ -74,6 +74,9 @@ See See .BR madvise (2). .P +Starting in Linux 6.13, when manipulating the calling process, any advice flag +is permitted. +.P The .I flags argument is reserved for future use; currently, this argument must be
Since Linux 6.13 it has become possible to use all madvise flags when targeting the calling process. Update the man page to reflect this change. Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> --- man/man2/process_madvise.2 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.47.1