[3/8] vfio/igd: remove unsupported device ids

Commit Message

Tomita Moeko Dec. 1, 2024, 4:09 p.m. UTC

Since e433f208973f ("vfio/igd: return an invalid generation for unknown
devices"), the default return of igd_gen() was changed to unsupported.
There is no need to filter out those unsupported devices.

Signed-off-by: Tomita Moeko <[e-mail]>
---
 hw/vfio/igd.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Alex Williamson Dec. 2, 2024, 5:30 a.m. UTC | #1

On Mon,  2 Dec 2024 00:09:33 +0800
Tomita Moeko <[e-mail]> wrote:

> Since e433f208973f ("vfio/igd: return an invalid generation for unknown
> devices"), the default return of igd_gen() was changed to unsupported.
> There is no need to filter out those unsupported devices.
> 
> Signed-off-by: Tomita Moeko <[e-mail]>
> ---
>  hw/vfio/igd.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
> index b449316ec0..8f300498e4 100644
> --- a/hw/vfio/igd.c
> +++ b/hw/vfio/igd.c
> @@ -64,16 +64,6 @@ static int igd_gen(VFIOPCIDevice *vdev)
>      }
>  
>      switch (vdev->device_id & 0xff00) {
> -    /* Old, untested, unavailable, unknown */
> -    case 0x0000:
> -    case 0x2500:
> -    case 0x2700:
> -    case 0x2900:
> -    case 0x2a00:
> -    case 0x2e00:
> -    case 0x3500:
> -    case 0xa000:
> -        return -1;
>      /* SandyBridge, IvyBridge, ValleyView, Haswell */
>      case 0x0100:
>      case 0x0400:

Reviewed-by: Alex Williamson <[e-mail]>

Corvin Köhne Dec. 2, 2024, 9:13 a.m. UTC | #2

On Sun, 2024-12-01 at 22:30 -0700, Alex Williamson wrote:
> CAUTION: External Email!!
> On Mon,  2 Dec 2024 00:09:33 +0800
> Tomita Moeko <[e-mail]> wrote:
> 
> > Since e433f208973f ("vfio/igd: return an invalid generation for
> > unknown
> > devices"), the default return of igd_gen() was changed to
> > unsupported.
> > There is no need to filter out those unsupported devices.
> > 
> > Signed-off-by: Tomita Moeko <[e-mail]>
> > ---
> >  hw/vfio/igd.c | 10 ----------
> >  1 file changed, 10 deletions(-)
> > 
> > diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
> > index b449316ec0..8f300498e4 100644
> > --- a/hw/vfio/igd.c
> > +++ b/hw/vfio/igd.c
> > @@ -64,16 +64,6 @@ static int igd_gen(VFIOPCIDevice *vdev)
> >      }
> >  
> >      switch (vdev->device_id & 0xff00) {
> > -    /* Old, untested, unavailable, unknown */
> > -    case 0x0000:
> > -    case 0x2500:
> > -    case 0x2700:
> > -    case 0x2900:
> > -    case 0x2a00:
> > -    case 0x2e00:
> > -    case 0x3500:
> > -    case 0xa000:
> > -        return -1;
> >      /* SandyBridge, IvyBridge, ValleyView, Haswell */
> >      case 0x0100:
> >      case 0x0400:
> 
> Reviewed-by: Alex Williamson <[e-mail]>
> 
> 

Reviewed-by: Corvin Köhne <[e-mail]>
disable-disclaimer-BADE

Patch

diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index b449316ec0..8f300498e4 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -64,16 +64,6 @@  static int igd_gen(VFIOPCIDevice *vdev)
     }
 
     switch (vdev->device_id & 0xff00) {
-    /* Old, untested, unavailable, unknown */
-    case 0x0000:
-    case 0x2500:
-    case 0x2700:
-    case 0x2900:
-    case 0x2a00:
-    case 0x2e00:
-    case 0x3500:
-    case 0xa000:
-        return -1;
     /* SandyBridge, IvyBridge, ValleyView, Haswell */
     case 0x0100:
     case 0x0400: