| Message ID | 20241202-starqltechn_integration_upstream-v9-4-a1adc3bae2b8@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Maxim Integrated MAX77705 PMIC | expand |
Hi Dzmitry, On 12/2/24 10:47, Dzmitry Sankouski wrote: > Add maxim,max77705 binding. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > Changes in v9: > - replace max77705 fuel gauge with max17042 > - remove monitored battery because not supported by max17042 > > Changes in v8: > - fix leds compatible > > Changes in v6: > - unevaluatedProperties must be false > - drop excessive sentence from description, > just describe the device > - change leds compatible to maxim,max77705-rgb > > Changes in v5: > - formatting changes > - add unevaluatedProperties: false for nodes referencing > common schemas > - remove additionalProperties on nodes with > unevaluatedProperties: false > - add min and max to led index > Changes in v4: > - change dts example intendation from tabs > to spaces > - remove interrupt-names property > - remove obvious reg description > - split long(>80) lines > --- > Documentation/devicetree/bindings/mfd/maxim,max77705.yaml | 155 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 156 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > new file mode 100644 > index 000000000000..fbc264cfc609 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > @@ -0,0 +1,155 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX77705 Companion Power Management IC and USB Type-C interface IC > + > +maintainers: > + - Dzmitry Sankouski <dsankouski@gmail.com> > + > +description: | > + The Maxim MAX77705 is a Companion Power Management and Type-C > + interface IC which includes charger, fuelgauge, LED, haptic motor driver and > + Type-C management IC. > + > +properties: > + compatible: > + const: maxim,max77705 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + charger: > + $ref: /schemas/power/supply/power-supply.yaml > + unevaluatedProperties: false > + properties: > + compatible: > + const: maxim,max77705-charger > + > + required: > + - compatible > + - monitored-battery > + > + fuel-gauge: > + $ref: /schemas/power/supply/maxim,max17042.yaml# > + > + haptic: > + type: object > + additionalProperties: false > + > + properties: > + compatible: > + const: maxim,max77705-haptic > + > + haptic-supply: true > + > + pwms: > + maxItems: 1 > + > + required: > + - compatible > + - haptic-supply > + - pwms > + > + leds: > + type: object > + additionalProperties: false > + description: > + Up to 4 LEDs supported. One LED is represented by one child node. > + > + properties: > + compatible: > + const: maxim,max77705-rgb > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^led@[0-3]$": > + $ref: /schemas/leds/common.yaml# > + type: object > + unevaluatedProperties: false > + > + properties: > + reg: > + description: LED index. > + minimum: 0 > + maximum: 3 > + > + required: > + - reg > + > + required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/leds/common.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@66 { > + compatible = "maxim,max77705"; > + reg = <0x66>; > + interrupt-parent = <&pm8998_gpios>; > + interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-0 = <&chg_int_default>; > + pinctrl-names = "default"; > + > + leds { > + compatible = "maxim,max77705-rgb"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + label = "red:usr1"; In the driver you're using devm_led_classdev_register_ext(), but in DT example you're proposing to use legacy 'label' property, instead of 'color' and 'function' devm_led_classdev_register_ext() is able to parse. Either use devm_led_classdev_register() (discouraged), or modify this example to use modern LED DT properties. > + }; > + > + led@2 { > + reg = <2>; > + label = "green:usr2"; > + }; > + > + led@3 { > + reg = <3>; > + label = "blue:usr3"; > + }; > + }; > + > + max77705_charger: charger { > + compatible = "maxim,max77705-charger"; > + monitored-battery = <&battery>; > + }; > + > + fuel-gauge { > + compatible = "maxim,max77705-battery"; > + power-supplies = <&max77705_charger>; > + maxim,rsns-microohm = <5000>; > + }; > + > + haptic { > + compatible = "maxim,max77705-haptic"; > + haptic-supply = <&vib_regulator>; > + pwms = <&vib_pwm 0 50000>; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 1240e75ecf4b..c3f66093edd1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14185,6 +14185,7 @@ B: mailto:linux-samsung-soc@vger.kernel.org > F: Documentation/devicetree/bindings/*/maxim,max14577.yaml > F: Documentation/devicetree/bindings/*/maxim,max77686.yaml > F: Documentation/devicetree/bindings/*/maxim,max77693.yaml > +F: Documentation/devicetree/bindings/*/maxim,max77705*.yaml > F: Documentation/devicetree/bindings/*/maxim,max77843.yaml > F: Documentation/devicetree/bindings/clock/maxim,max77686.txt > F: drivers/*/*max77843.c >
diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml new file mode 100644 index 000000000000..fbc264cfc609 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml @@ -0,0 +1,155 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX77705 Companion Power Management IC and USB Type-C interface IC + +maintainers: + - Dzmitry Sankouski <dsankouski@gmail.com> + +description: | + The Maxim MAX77705 is a Companion Power Management and Type-C + interface IC which includes charger, fuelgauge, LED, haptic motor driver and + Type-C management IC. + +properties: + compatible: + const: maxim,max77705 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + charger: + $ref: /schemas/power/supply/power-supply.yaml + unevaluatedProperties: false + properties: + compatible: + const: maxim,max77705-charger + + required: + - compatible + - monitored-battery + + fuel-gauge: + $ref: /schemas/power/supply/maxim,max17042.yaml# + + haptic: + type: object + additionalProperties: false + + properties: + compatible: + const: maxim,max77705-haptic + + haptic-supply: true + + pwms: + maxItems: 1 + + required: + - compatible + - haptic-supply + - pwms + + leds: + type: object + additionalProperties: false + description: + Up to 4 LEDs supported. One LED is represented by one child node. + + properties: + compatible: + const: maxim,max77705-rgb + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + patternProperties: + "^led@[0-3]$": + $ref: /schemas/leds/common.yaml# + type: object + unevaluatedProperties: false + + properties: + reg: + description: LED index. + minimum: 0 + maximum: 3 + + required: + - reg + + required: + - compatible + - "#address-cells" + - "#size-cells" + +required: + - compatible + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/leds/common.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pmic@66 { + compatible = "maxim,max77705"; + reg = <0x66>; + interrupt-parent = <&pm8998_gpios>; + interrupts = <11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-0 = <&chg_int_default>; + pinctrl-names = "default"; + + leds { + compatible = "maxim,max77705-rgb"; + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <1>; + label = "red:usr1"; + }; + + led@2 { + reg = <2>; + label = "green:usr2"; + }; + + led@3 { + reg = <3>; + label = "blue:usr3"; + }; + }; + + max77705_charger: charger { + compatible = "maxim,max77705-charger"; + monitored-battery = <&battery>; + }; + + fuel-gauge { + compatible = "maxim,max77705-battery"; + power-supplies = <&max77705_charger>; + maxim,rsns-microohm = <5000>; + }; + + haptic { + compatible = "maxim,max77705-haptic"; + haptic-supply = <&vib_regulator>; + pwms = <&vib_pwm 0 50000>; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 1240e75ecf4b..c3f66093edd1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14185,6 +14185,7 @@ B: mailto:linux-samsung-soc@vger.kernel.org F: Documentation/devicetree/bindings/*/maxim,max14577.yaml F: Documentation/devicetree/bindings/*/maxim,max77686.yaml F: Documentation/devicetree/bindings/*/maxim,max77693.yaml +F: Documentation/devicetree/bindings/*/maxim,max77705*.yaml F: Documentation/devicetree/bindings/*/maxim,max77843.yaml F: Documentation/devicetree/bindings/clock/maxim,max77686.txt F: drivers/*/*max77843.c