[v2,0/3] iio: pressure: bmp280: Minor cleanup

Message

Vasileios Amoiridis Dec. 2, 2024, 6:19 p.m. UTC

Changes in v2:

Patch 1/3:
	- Switch if case for better readability

Patch 2/3:
	- Reword commit message

---
v1: https://lore.kernel.org/linux-iio/[e-mail]/

This series adds the SPI interface description on the device-tree file
of the sensor, adds proper self-described sized variables and performs
a minor optimization in time variable names.

Vasileios Amoiridis (3):
  dt-bindings: iio: pressure: bmp085: Add SPI interface
  iio: pressure: bmp280: Use sizeof() for denominator
  iio: pressure: bmp280: Make time vars intuitive and move to fsleep

 .../bindings/iio/pressure/bmp085.yaml         | 32 +++++++++++++++
 drivers/iio/pressure/bmp280-core.c            | 39 ++++++++++---------
 drivers/iio/pressure/bmp280.h                 |  8 ++--
 3 files changed, 56 insertions(+), 23 deletions(-)


base-commit: a61ff7eac77e86de828fe28c4e42b8ae9ec2b195

Comments

Andy Shevchenko Dec. 2, 2024, 6:42 p.m. UTC | #1

On Mon, Dec 02, 2024 at 07:19:04PM +0100, Vasileios Amoiridis wrote:
> Changes in v2:
> 
> Patch 1/3:
> 	- Switch if case for better readability
> 
> Patch 2/3:
> 	- Reword commit message
> 
> ---
> v1: https://lore.kernel.org/linux-iio/[e-mail]/
> 
> This series adds the SPI interface description on the device-tree file
> of the sensor, adds proper self-described sized variables and performs
> a minor optimization in time variable names.

For some reason your patches still have v1 in them. I dunno how you prepare
your series but I recommend one of the two options:
1) b4 relay
2) my script: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

Vasileios Amoiridis Dec. 2, 2024, 7:24 p.m. UTC | #2

On Mon, Dec 02, 2024 at 08:42:04PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 02, 2024 at 07:19:04PM +0100, Vasileios Amoiridis wrote:
> > Changes in v2:
> > 
> > Patch 1/3:
> > 	- Switch if case for better readability
> > 
> > Patch 2/3:
> > 	- Reword commit message
> > 
> > ---
> > v1: https://lore.kernel.org/linux-iio/[e-mail]/
> > 
> > This series adds the SPI interface description on the device-tree file
> > of the sensor, adds proper self-described sized variables and performs
> > a minor optimization in time variable names.
> 
> For some reason your patches still have v1 in them. I dunno how you prepare
> your series but I recommend one of the two options:
> 1) b4 relay
> 2) my script: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>

Hi Andy,

Ah, my mistake! I didn't pay close attention. I use the --reroll-count
from git format-patch. I was not aware of those automated ways, I will
definitely use them. Thanks for pointing it out.

The patches are correct, the versioning is wrong, I can resend them if it
is necessary. 

Cheers,
Vasilis

Andy Shevchenko Dec. 2, 2024, 7:39 p.m. UTC | #3

On Mon, Dec 02, 2024 at 08:24:48PM +0100, Vasileios Amoiridis wrote:
> On Mon, Dec 02, 2024 at 08:42:04PM +0200, Andy Shevchenko wrote:
> > On Mon, Dec 02, 2024 at 07:19:04PM +0100, Vasileios Amoiridis wrote:

...

> > > Changes in v2:
> > > 
> > > Patch 1/3:
> > > 	- Switch if case for better readability
> > > 
> > > Patch 2/3:
> > > 	- Reword commit message
> > > 
> > > ---
> > > v1: https://lore.kernel.org/linux-iio/[e-mail]/
> > > 
> > > This series adds the SPI interface description on the device-tree file
> > > of the sensor, adds proper self-described sized variables and performs
> > > a minor optimization in time variable names.
> > 
> > For some reason your patches still have v1 in them. I dunno how you prepare
> > your series but I recommend one of the two options:
> > 1) b4 relay
> > 2) my script: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

> Ah, my mistake! I didn't pay close attention. I use the --reroll-count
> from git format-patch. I was not aware of those automated ways, I will
> definitely use them. Thanks for pointing it out.
> 
> The patches are correct, the versioning is wrong, I can resend them if it
> is necessary. 

Up to Jonathan, if the patches are correct, I don't see the necessity of
resending until there are some issues being noted.