| Message ID | 20241202125437.1154945-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/display: remove unused for_each_crtc() | expand |
Quoting Jani Nikula (2024-12-02 09:54:37-03:00) >This is essentially a duplicate of drm_for_each_crtc() anyway. Remove. And it looks like commit 08dfd243abac ("drm/i915: Clean up intel_fbdev_init_bios() a bit") was the one that made it unused. > >Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com> >--- > drivers/gpu/drm/i915/display/intel_display.h | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h >index caef04f655c5..49a246feb1ae 100644 >--- a/drivers/gpu/drm/i915/display/intel_display.h >+++ b/drivers/gpu/drm/i915/display/intel_display.h >@@ -238,9 +238,6 @@ enum phy_fia { > for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++) \ > for_each_if((__phys_mask) & BIT(__phy)) > >-#define for_each_crtc(dev, crtc) \ >- list_for_each_entry(crtc, &(dev)->mode_config.crtc_list, head) >- > #define for_each_intel_plane(dev, intel_plane) \ > list_for_each_entry(intel_plane, \ > &(dev)->mode_config.plane_list, \ >-- >2.39.5 >
On Mon, 02 Dec 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote: > Quoting Jani Nikula (2024-12-02 09:54:37-03:00) >>This is essentially a duplicate of drm_for_each_crtc() anyway. Remove. > > And it looks like commit 08dfd243abac ("drm/i915: Clean up > intel_fbdev_init_bios() a bit") was the one that made it unused. > >> >>Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com> Thanks for the review, pushed to din. BR, Jani. > >>--- >> drivers/gpu/drm/i915/display/intel_display.h | 3 --- >> 1 file changed, 3 deletions(-) >> >>diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h >>index caef04f655c5..49a246feb1ae 100644 >>--- a/drivers/gpu/drm/i915/display/intel_display.h >>+++ b/drivers/gpu/drm/i915/display/intel_display.h >>@@ -238,9 +238,6 @@ enum phy_fia { >> for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++) \ >> for_each_if((__phys_mask) & BIT(__phy)) >> >>-#define for_each_crtc(dev, crtc) \ >>- list_for_each_entry(crtc, &(dev)->mode_config.crtc_list, head) >>- >> #define for_each_intel_plane(dev, intel_plane) \ >> list_for_each_entry(intel_plane, \ >> &(dev)->mode_config.plane_list, \ >>-- >>2.39.5 >>
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h index caef04f655c5..49a246feb1ae 100644 --- a/drivers/gpu/drm/i915/display/intel_display.h +++ b/drivers/gpu/drm/i915/display/intel_display.h @@ -238,9 +238,6 @@ enum phy_fia { for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++) \ for_each_if((__phys_mask) & BIT(__phy)) -#define for_each_crtc(dev, crtc) \ - list_for_each_entry(crtc, &(dev)->mode_config.crtc_list, head) - #define for_each_intel_plane(dev, intel_plane) \ list_for_each_entry(intel_plane, \ &(dev)->mode_config.plane_list, \
This is essentially a duplicate of drm_for_each_crtc() anyway. Remove. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_display.h | 3 --- 1 file changed, 3 deletions(-)