| Message ID | 20241202114149.2666-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [f2fs-dev,1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line | expand |
On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote: > The bug related to this regression testcase has been fixed by commit > d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call > f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit > line. > > Cc: Jaegeuk Kim <jaegeuk@kernel.org> > Signed-off-by: Chao Yu <chao@kernel.org> > --- > tests/f2fs/005 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/f2fs/005 b/tests/f2fs/005 > index a817d51a..33d4fdb9 100755 > --- a/tests/f2fs/005 > +++ b/tests/f2fs/005 > @@ -11,7 +11,7 @@ > . ./common/preamble > _begin_fstest auto quick > > -_fixed_by_kernel_commit xxxxxxxxxxxx \ > +_fixed_by_kernel_commit d5c367ef8287 \ > "f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode." I think we don't need to use 3 patches. As you just add missed commit id number, just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit". Or if you hope I can do that when I merge it, feel free to tell me :) Others look good to me, with above change: Reviewed-by: Zorro Lang <zlang@redhat.com> > > _require_scratch > -- > 2.40.1 >
On 2024/12/3 3:28, Zorro Lang wrote: > On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote: >> The bug related to this regression testcase has been fixed by commit >> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call >> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit >> line. >> >> Cc: Jaegeuk Kim <jaegeuk@kernel.org> >> Signed-off-by: Chao Yu <chao@kernel.org> >> --- >> tests/f2fs/005 | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/f2fs/005 b/tests/f2fs/005 >> index a817d51a..33d4fdb9 100755 >> --- a/tests/f2fs/005 >> +++ b/tests/f2fs/005 >> @@ -11,7 +11,7 @@ >> . ./common/preamble >> _begin_fstest auto quick >> >> -_fixed_by_kernel_commit xxxxxxxxxxxx \ >> +_fixed_by_kernel_commit d5c367ef8287 \ >> "f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode." > > I think we don't need to use 3 patches. As you just add missed commit id number, > just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit". > Or if you hope I can do that when I merge it, feel free to tell me :) Zorro, I've sent a new patch, can you please help to review it? thank you. Thanks, > > Others look good to me, with above change: > > Reviewed-by: Zorro Lang <zlang@redhat.com> > >> >> _require_scratch >> -- >> 2.40.1 >> >
diff --git a/tests/f2fs/005 b/tests/f2fs/005 index a817d51a..33d4fdb9 100755 --- a/tests/f2fs/005 +++ b/tests/f2fs/005 @@ -11,7 +11,7 @@ . ./common/preamble _begin_fstest auto quick -_fixed_by_kernel_commit xxxxxxxxxxxx \ +_fixed_by_kernel_commit d5c367ef8287 \ "f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode." _require_scratch
The bug related to this regression testcase has been fixed by commit d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit line. Cc: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Chao Yu <chao@kernel.org> --- tests/f2fs/005 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)