diff mbox series

hwmon: (nct6775): Actually make use of the HWMON_NCT6775 symbol namespace

Message ID 20241203173149.1648456-2-u.kleine-koenig@baylibre.com (mailing list archive)
State Accepted
Headers show
Series hwmon: (nct6775): Actually make use of the HWMON_NCT6775 symbol namespace | expand

Commit Message

Uwe Kleine-König Dec. 3, 2024, 5:31 p.m. UTC
DEFAULT_SYMBOL_NAMESPACE must already be defined when <linux/export.h>
is included. So move the define above the include block.

Fixes: c3963bc0a0cf ("hwmon: (nct6775) Split core and platform driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Hello,

this is based on current Linus Torvalds's master branch and depends on
the topmost commit there.

Best regards
Uwe

 drivers/hwmon/nct6775-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: ceb8bf2ceaa77fe222fe8fe32cb7789c9099ddf1

Comments

Guenter Roeck Dec. 3, 2024, 5:39 p.m. UTC | #1
On Tue, Dec 03, 2024 at 06:31:49PM +0100, Uwe Kleine-König wrote:
> DEFAULT_SYMBOL_NAMESPACE must already be defined when <linux/export.h>
> is included. So move the define above the include block.
> 
> Fixes: c3963bc0a0cf ("hwmon: (nct6775) Split core and platform driver")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> this is based on current Linus Torvalds's master branch and depends on
> the topmost commit there.
> 

That API change is causing all kinds of trouble for me :-(.
Never mind, good catch. Applied.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c
index c243b51837d2..fa3351351825 100644
--- a/drivers/hwmon/nct6775-core.c
+++ b/drivers/hwmon/nct6775-core.c
@@ -42,6 +42,9 @@ 
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
+#undef DEFAULT_SYMBOL_NAMESPACE
+#define DEFAULT_SYMBOL_NAMESPACE "HWMON_NCT6775"
+
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
@@ -56,9 +59,6 @@ 
 #include "lm75.h"
 #include "nct6775.h"
 
-#undef DEFAULT_SYMBOL_NAMESPACE
-#define DEFAULT_SYMBOL_NAMESPACE "HWMON_NCT6775"
-
 #define USE_ALTERNATE
 
 /* used to set data->name = nct6775_device_names[data->sio_kind] */