| Message ID | 20241204140857.1691402-2-u.kleine-koenig@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (isl28022) Drop explicit initialization of struct i2c_device_id::driver_data to 0 | expand |
On Wed, Dec 04, 2024 at 03:08:57PM +0100, Uwe Kleine-König wrote: > This driver doesn't use the driver_data member of struct i2c_device_id, > so don't explicitly initialize it. > > This prepares putting driver_data in an anonymous union which requires > either no initialization or named designators. But it's also a nice > cleanup on its own. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> > --- Applied. Thanks, Guenter
diff --git a/drivers/hwmon/isl28022.c b/drivers/hwmon/isl28022.c index f9edcfd164c2..04414075afe8 100644 --- a/drivers/hwmon/isl28022.c +++ b/drivers/hwmon/isl28022.c @@ -486,7 +486,7 @@ static int isl28022_probe(struct i2c_client *client) } static const struct i2c_device_id isl28022_ids[] = { - { "isl28022", 0}, + { "isl28022" }, { /* LIST END */ } }; MODULE_DEVICE_TABLE(i2c, isl28022_ids);
This driver doesn't use the driver_data member of struct i2c_device_id, so don't explicitly initialize it. This prepares putting driver_data in an anonymous union which requires either no initialization or named designators. But it's also a nice cleanup on its own. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> --- Hello, this driver didn't exist yet when I created the patch that has become a7e03f96791e ("hwmon: Drop explicit initialization of struct i2c_device_id::driver_data to 0"). So it's converted here on it's own. Best regards Uwe drivers/hwmon/isl28022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: c245a7a79602ccbee780c004c1e4abcda66aec32