| Message ID | 20241204140208.2701268-1-yuyanghuang@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | David Ahern |
| Headers | show |
| Series | [iproute2-next,v3,1/2] iproute2: expose netlink constants in UAPI | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Wed, 4 Dec 2024 23:02:07 +0900 Yuyang Huang <yuyanghuang@google.com> wrote: > This change adds the following multicast related netlink constants to > the UAPI: > > * RTNLGRP_IPV4_MCADDR and RTNLGRP_IPV6_MCADDR: Netlink multicast > groups for IPv4 and IPv6 multicast address changes. > * RTM_NEWMULTICAST and RTM_DELMULTICAST: Netlink message types for > multicast address additions and deletions. > > Exposing these constants in the UAPI enables ip monitor to effectively > monitor and manage multicast group memberships. > > Cc: Maciej Żenczykowski <maze@google.com> > Cc: Lorenzo Colitti <lorenzo@google.com> > Signed-off-by: Yuyang Huang <yuyanghuang@google.com> > --- This should get automatically picked up when David does header update.
> This should get automatically picked up when David does header update. Thanks for the suggestion, I need the header patch to make my patch series build. Based on the previous review feedback, when David merges the patch series, this patch will be skipped. Link: https://lore.kernel.org/netdev/c97dd18b-8f67-4d22-a088-d73268402261@kernel.org/ Thanks, Yuyang On Thu, Dec 5, 2024 at 1:29 AM Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Wed, 4 Dec 2024 23:02:07 +0900 > Yuyang Huang <yuyanghuang@google.com> wrote: > > > This change adds the following multicast related netlink constants to > > the UAPI: > > > > * RTNLGRP_IPV4_MCADDR and RTNLGRP_IPV6_MCADDR: Netlink multicast > > groups for IPv4 and IPv6 multicast address changes. > > * RTM_NEWMULTICAST and RTM_DELMULTICAST: Netlink message types for > > multicast address additions and deletions. > > > > Exposing these constants in the UAPI enables ip monitor to effectively > > monitor and manage multicast group memberships. > > > > Cc: Maciej Żenczykowski <maze@google.com> > > Cc: Lorenzo Colitti <lorenzo@google.com> > > Signed-off-by: Yuyang Huang <yuyanghuang@google.com> > > --- > > This should get automatically picked up when David does header update.
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index 4e6c8e14..04be20ee 100644 --- a/include/uapi/linux/rtnetlink.h +++ b/include/uapi/linux/rtnetlink.h @@ -93,7 +93,11 @@ enum { RTM_NEWPREFIX = 52, #define RTM_NEWPREFIX RTM_NEWPREFIX - RTM_GETMULTICAST = 58, + RTM_NEWMULTICAST = 56, +#define RTM_NEWMULTICAST RTM_NEWMULTICAST + RTM_DELMULTICAST, +#define RTM_DELMULTICAST RTM_DELMULTICAST + RTM_GETMULTICAST, #define RTM_GETMULTICAST RTM_GETMULTICAST RTM_GETANYCAST = 62, @@ -772,6 +776,10 @@ enum rtnetlink_groups { #define RTNLGRP_TUNNEL RTNLGRP_TUNNEL RTNLGRP_STATS, #define RTNLGRP_STATS RTNLGRP_STATS + RTNLGRP_IPV4_MCADDR, +#define RTNLGRP_IPV4_MCADDR RTNLGRP_IPV4_MCADDR + RTNLGRP_IPV6_MCADDR, +#define RTNLGRP_IPV6_MCADDR RTNLGRP_IPV6_MCADDR __RTNLGRP_MAX }; #define RTNLGRP_MAX (__RTNLGRP_MAX - 1)
This change adds the following multicast related netlink constants to the UAPI: * RTNLGRP_IPV4_MCADDR and RTNLGRP_IPV6_MCADDR: Netlink multicast groups for IPv4 and IPv6 multicast address changes. * RTM_NEWMULTICAST and RTM_DELMULTICAST: Netlink message types for multicast address additions and deletions. Exposing these constants in the UAPI enables ip monitor to effectively monitor and manage multicast group memberships. Cc: Maciej Żenczykowski <maze@google.com> Cc: Lorenzo Colitti <lorenzo@google.com> Signed-off-by: Yuyang Huang <yuyanghuang@google.com> --- Changelog since v2: - Align RTM_NEWMULTICAST and RTM_GETMULTICAST enum definitions with existing code style. include/uapi/linux/rtnetlink.h | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)