| Message ID | 20241204182451.144381-7-l.rubusch@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events | expand |
On Wed, Dec 04, 2024 at 06:24:47PM +0000, Lothar Rubusch wrote: > Add interrupt-names INT1 and INT2 for the two interrupt lines of the > sensor. Only one line will be connected for incoming events. The driver > needs to be configured accordingly. If no interrupt line is set up, the > sensor will still measure, but no events are possible. > > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com> > --- > .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > index 280ed479ef5..a4c2cefe1a4 100644 > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > @@ -37,6 +37,15 @@ properties: > interrupts: > maxItems: 1 > > + interrupt-names: > + description: Use either INT1 or INT2 for events, or ignore events. > + minItems: 1 > + maxItems: 2 No improvements, no responses and according to commit msg you have only one item, so instead above and below just: description: ......... items: - enum: [ int1, int2] Best regards, Krzysztof
On Thu, Dec 5, 2024 at 9:55 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Wed, Dec 04, 2024 at 06:24:47PM +0000, Lothar Rubusch wrote: > > Add interrupt-names INT1 and INT2 for the two interrupt lines of the > > sensor. Only one line will be connected for incoming events. The driver > > needs to be configured accordingly. If no interrupt line is set up, the > > sensor will still measure, but no events are possible. > > > > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com> > > --- > > .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > > index 280ed479ef5..a4c2cefe1a4 100644 > > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > > @@ -37,6 +37,15 @@ properties: > > interrupts: > > maxItems: 1 > > > > + interrupt-names: > > + description: Use either INT1 or INT2 for events, or ignore events. > > + minItems: 1 > > + maxItems: 2 > > No improvements, no responses and according to commit msg you have only That's not true. Indention was now fixed. > one item, so instead above and below just: > > description: ......... > items: > - enum: [ int1, int2] Yes. Unfortunately you're right. I was not aware of the [] writing. Much better! Sorry, for wasting your time with that. I learned to not just copy&paste w/o running the lengthy dt_binding_check. Fixed version is coming up. Best, L > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml index 280ed479ef5..a4c2cefe1a4 100644 --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml @@ -37,6 +37,15 @@ properties: interrupts: maxItems: 1 + interrupt-names: + description: Use either INT1 or INT2 for events, or ignore events. + minItems: 1 + maxItems: 2 + items: + enum: + - INT1 + - INT2 + required: - compatible - reg @@ -61,6 +70,7 @@ examples: reg = <0x2a>; interrupt-parent = <&gpio0>; interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "INT1"; }; }; - | @@ -79,5 +89,6 @@ examples: spi-cpha; interrupt-parent = <&gpio0>; interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "INT2"; }; };
Add interrupt-names INT1 and INT2 for the two interrupt lines of the sensor. Only one line will be connected for incoming events. The driver needs to be configured accordingly. If no interrupt line is set up, the sensor will still measure, but no events are possible. Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com> --- .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)