| Message ID | 20241205145859.2331691-2-mkumard@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Tegra ADMA channel page support | expand |
On 05/12/2024 15:58, Mohan Kumar D wrote: > Multiple ADMA Channel page hardware support has been added from > TEGRA186 and onwards. Update the DT binding to use any of the > ADMA channel page address space region. > > Signed-off-by: Mohan Kumar D <mkumard@nvidia.com> > --- > .../bindings/dma/nvidia,tegra210-adma.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml > index 877147e95ecc..8c76c98560c5 100644 > --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml > @@ -29,7 +29,24 @@ properties: > - const: nvidia,tegra186-adma > > reg: > - maxItems: 1 > + description: | Do not need '|' unless you need to preserve formatting. > + The 'page' region describes the address space of the page > + used for accessing the DMA channel registers. The 'global' > + region describes the address space of the global DMA registers. > + In the absence of the 'reg-names' property, there must be a > + single entry that covers the address space of the global DMA > + registers and the DMA channel registers. Rather oneOf listing the items with description. > + minItems: 1 > + maxItems: 2 > + > + reg-names: > + oneOf: > + - enum: > + - page > + - global This is not correct. You said it covers both. You also need allOf:if:then: block restricting it per each variant/device. Best regards, Krzysztof
On 05-12-2024 20:45, Krzysztof Kozlowski wrote: > External email: Use caution opening links or attachments > > > On 05/12/2024 15:58, Mohan Kumar D wrote: >> Multiple ADMA Channel page hardware support has been added from >> TEGRA186 and onwards. Update the DT binding to use any of the >> ADMA channel page address space region. >> >> Signed-off-by: Mohan Kumar D <mkumard@nvidia.com> >> --- >> .../bindings/dma/nvidia,tegra210-adma.yaml | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml >> index 877147e95ecc..8c76c98560c5 100644 >> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml >> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml >> @@ -29,7 +29,24 @@ properties: >> - const: nvidia,tegra186-adma >> >> reg: >> - maxItems: 1 >> + description: | > Do not need '|' unless you need to preserve formatting. Acknowledge. >> + The 'page' region describes the address space of the page >> + used for accessing the DMA channel registers. The 'global' >> + region describes the address space of the global DMA registers. >> + In the absence of the 'reg-names' property, there must be a >> + single entry that covers the address space of the global DMA >> + registers and the DMA channel registers. > Rather oneOf listing the items with description. Acknowledge. will fix in next patch. > >> + minItems: 1 >> + maxItems: 2 >> + >> + reg-names: >> + oneOf: >> + - enum: >> + - page >> + - global > This is not correct. You said it covers both. > > You also need allOf:if:then: block restricting it per each variant/device. I will fix the above concern with the next patch version which will have clear variant/device specific restriction on reg-names property usage. > > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml index 877147e95ecc..8c76c98560c5 100644 --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml @@ -29,7 +29,24 @@ properties: - const: nvidia,tegra186-adma reg: - maxItems: 1 + description: | + The 'page' region describes the address space of the page + used for accessing the DMA channel registers. The 'global' + region describes the address space of the global DMA registers. + In the absence of the 'reg-names' property, there must be a + single entry that covers the address space of the global DMA + registers and the DMA channel registers. + minItems: 1 + maxItems: 2 + + reg-names: + oneOf: + - enum: + - page + - global + - items: + - const: page + - const: global interrupts: description: |
Multiple ADMA Channel page hardware support has been added from TEGRA186 and onwards. Update the DT binding to use any of the ADMA channel page address space region. Signed-off-by: Mohan Kumar D <mkumard@nvidia.com> --- .../bindings/dma/nvidia,tegra210-adma.yaml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)