diff mbox series

[bpf-next,1/1] selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata

Message ID 20241204115715.3148412-1-yoong.siang.song@intel.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series [bpf-next,1/1] selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for bpf-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success Errors and warnings before: 0 (+0) this patch: 0 (+0)
netdev/cc_maintainers success CCed 19 of 19 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 15 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-PR success PR summary
bpf/vmtest-bpf-next-VM_Test-0 success Logs for Lint
bpf/vmtest-bpf-next-VM_Test-1 success Logs for ShellCheck
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Unittests
bpf/vmtest-bpf-next-VM_Test-3 success Logs for Validate matrix.py
bpf/vmtest-bpf-next-VM_Test-5 success Logs for aarch64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-4 success Logs for aarch64-gcc / build / build for aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-6 success Logs for aarch64-gcc / test (sched_ext, false, 360) / sched_ext on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-30 success Logs for x86_64-llvm-17 / build-release / build for x86_64 with llvm-17-O2
bpf/vmtest-bpf-next-VM_Test-12 success Logs for s390x-gcc / build / build for s390x with gcc
bpf/vmtest-bpf-next-VM_Test-21 success Logs for x86_64-gcc / test (sched_ext, false, 360) / sched_ext on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-11 success Logs for aarch64-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-20 success Logs for x86_64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-18 success Logs for set-matrix
bpf/vmtest-bpf-next-VM_Test-17 success Logs for s390x-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-19 success Logs for x86_64-gcc / build / build for x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-10 success Logs for aarch64-gcc / test (test_verifier, false, 360) / test_verifier on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-35 success Logs for x86_64-llvm-17 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-27 success Logs for x86_64-gcc / test (test_verifier, false, 360) / test_verifier on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-13 success Logs for s390x-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-16 success Logs for s390x-gcc / test (test_verifier, false, 360) / test_verifier on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-38 success Logs for x86_64-llvm-18 / build-release / build for x86_64 with llvm-18-O2
bpf/vmtest-bpf-next-VM_Test-29 success Logs for x86_64-llvm-17 / build / build for x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-37 success Logs for x86_64-llvm-18 / build / build for x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-45 success Logs for x86_64-llvm-18 / veristat
bpf/vmtest-bpf-next-VM_Test-36 success Logs for x86_64-llvm-17 / veristat
bpf/vmtest-bpf-next-VM_Test-24 success Logs for x86_64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-9 success Logs for aarch64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-28 success Logs for x86_64-gcc / veristat / veristat on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-31 success Logs for x86_64-llvm-17 / test (sched_ext, false, 360) / sched_ext on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-8 success Logs for aarch64-gcc / test (test_progs, false, 360) / test_progs on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-15 success Logs for s390x-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-22 success Logs for x86_64-gcc / test (test_maps, false, 360) / test_maps on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-32 success Logs for x86_64-llvm-17 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-40 success Logs for x86_64-llvm-18 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-26 success Logs for x86_64-gcc / test (test_progs_parallel, true, 30) / test_progs_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-33 success Logs for x86_64-llvm-17 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-43 success Logs for x86_64-llvm-18 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-25 success Logs for x86_64-gcc / test (test_progs_no_alu32_parallel, true, 30) / test_progs_no_alu32_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-42 success Logs for x86_64-llvm-18 / test (test_progs_cpuv4, false, 360) / test_progs_cpuv4 on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-23 success Logs for x86_64-gcc / test (test_progs, false, 360) / test_progs on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-39 success Logs for x86_64-llvm-18 / test (sched_ext, false, 360) / sched_ext on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-41 success Logs for x86_64-llvm-18 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-44 success Logs for x86_64-llvm-18 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-7 success Logs for aarch64-gcc / test (test_maps, false, 360) / test_maps on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-34 success Logs for x86_64-llvm-17 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-14 success Logs for s390x-gcc / test (test_progs, false, 360) / test_progs on s390x with gcc

Commit Message

Song, Yoong Siang Dec. 4, 2024, 11:57 a.m. UTC 
Set tx_type to HWTSTAMP_TX_ON to enable hardware timestamping for all
outgoing packets.

Besides, set XDP_UMEM_TX_METADATA_LEN flag to reserve tx_metadata_len bytes
of per-chunk metadata.

Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
---
 tools/testing/selftests/bpf/xdp_hw_metadata.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Stanislav Fomichev Dec. 4, 2024, 3:48 p.m. UTC | #1 
On 12/04, Song Yoong Siang wrote:
> Set tx_type to HWTSTAMP_TX_ON to enable hardware timestamping for all
> outgoing packets.
> 
> Besides, set XDP_UMEM_TX_METADATA_LEN flag to reserve tx_metadata_len bytes
> of per-chunk metadata.

XDP_UMEM_TX_METADATA_LEN is missing after d5e726d9143c ("xsk: Require
XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"), so that make
sense. Maybe add a fixes tag?

And I don't see mlx5 looking at HWTSTAMP_TX anywhere in the drivers,
so I'm assuming that's why I didn't need HWTSTAMP_TX_ON during my tests..
Which device are you testing against? I do see some hwts_tx_en
checks in the stfmmac at least... Can you add these details to the
commit message and respin?

With the above addressed:
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Song, Yoong Siang Dec. 5, 2024, 1:36 a.m. UTC | #2 
On Wednesday, December 4, 2024 11:49 PM, Stanislav Fomichev <stfomichev@gmail.com> wrote:
>On 12/04, Song Yoong Siang wrote:
>> Set tx_type to HWTSTAMP_TX_ON to enable hardware timestamping for all
>> outgoing packets.
>>
>> Besides, set XDP_UMEM_TX_METADATA_LEN flag to reserve tx_metadata_len bytes
>> of per-chunk metadata.
>
>XDP_UMEM_TX_METADATA_LEN is missing after d5e726d9143c ("xsk: Require
>XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"), so that make
>sense. Maybe add a fixes tag?
>

Sure. I will add the fixes tag and submit with "PATCH bpf" prefix
in next version.

>And I don't see mlx5 looking at HWTSTAMP_TX anywhere in the drivers,
>so I'm assuming that's why I didn't need HWTSTAMP_TX_ON during my tests..
>Which device are you testing against? I do see some hwts_tx_en
>checks in the stfmmac at least... Can you add these details to the
>commit message and respin?
>

I am testing on stmmac and igc drivers.
You are right, stmmac needs it for hwts_tx_en check.
Besides, igc needs it to set IGC_RING_FLAG_TX_HWTSTAMP flag.

Without this patch, user will need to manually enable tx hwts using
command: sudo hwstamp_ctl -i eth0 -t 1 -r 1
after start xdp_hw_metadata.

Therefore, adding HWTSTAMP_TX_ON is not a bug fix solution.
I will separate this as another new patch to "PATCH bpf-next"
and provide detail in commit message.

Btw, is mlx5 driver always enable Tx HWTS?

>With the above addressed:
>Acked-by: Stanislav Fomichev <sdf@fomichev.me>

Thanks & Regards
Siang
Stanislav Fomichev Dec. 5, 2024, 7:25 p.m. UTC | #3 
On 12/05, Song, Yoong Siang wrote:
> On Wednesday, December 4, 2024 11:49 PM, Stanislav Fomichev <stfomichev@gmail.com> wrote:
> >On 12/04, Song Yoong Siang wrote:
> >> Set tx_type to HWTSTAMP_TX_ON to enable hardware timestamping for all
> >> outgoing packets.
> >>
> >> Besides, set XDP_UMEM_TX_METADATA_LEN flag to reserve tx_metadata_len bytes
> >> of per-chunk metadata.
> >
> >XDP_UMEM_TX_METADATA_LEN is missing after d5e726d9143c ("xsk: Require
> >XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"), so that make
> >sense. Maybe add a fixes tag?
> >
> 
> Sure. I will add the fixes tag and submit with "PATCH bpf" prefix
> in next version.
> 
> >And I don't see mlx5 looking at HWTSTAMP_TX anywhere in the drivers,
> >so I'm assuming that's why I didn't need HWTSTAMP_TX_ON during my tests..
> >Which device are you testing against? I do see some hwts_tx_en
> >checks in the stfmmac at least... Can you add these details to the
> >commit message and respin?
> >
> 
> I am testing on stmmac and igc drivers.
> You are right, stmmac needs it for hwts_tx_en check.
> Besides, igc needs it to set IGC_RING_FLAG_TX_HWTSTAMP flag.
> 
> Without this patch, user will need to manually enable tx hwts using
> command: sudo hwstamp_ctl -i eth0 -t 1 -r 1
> after start xdp_hw_metadata.
> 
> Therefore, adding HWTSTAMP_TX_ON is not a bug fix solution.
> I will separate this as another new patch to "PATCH bpf-next"
> and provide detail in commit message.
> 
> Btw, is mlx5 driver always enable Tx HWTS?

I don't remember doing anything special to enable it. And looking at
the code I also don't see any conditionals on HWTSTAMP_TX_ON.
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c
index 06266aad2f99..6f7b15d6c6ed 100644
--- a/tools/testing/selftests/bpf/xdp_hw_metadata.c
+++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c
@@ -79,7 +79,7 @@  static int open_xsk(int ifindex, struct xsk *xsk, __u32 queue_id)
 		.fill_size = XSK_RING_PROD__DEFAULT_NUM_DESCS,
 		.comp_size = XSK_RING_CONS__DEFAULT_NUM_DESCS,
 		.frame_size = XSK_UMEM__DEFAULT_FRAME_SIZE,
-		.flags = XSK_UMEM__DEFAULT_FLAGS,
+		.flags = XDP_UMEM_TX_METADATA_LEN,
 		.tx_metadata_len = sizeof(struct xsk_tx_metadata),
 	};
 	__u32 idx = 0;
@@ -551,6 +551,7 @@  static void hwtstamp_enable(const char *ifname)
 {
 	struct hwtstamp_config cfg = {
 		.rx_filter = HWTSTAMP_FILTER_ALL,
+		.tx_type = HWTSTAMP_TX_ON,
 	};
 
 	hwtstamp_ioctl(SIOCGHWTSTAMP, ifname, &saved_hwtstamp_cfg);