diff mbox series

[RFC] multipath-tools: add HPE MSA Gen7 (2070/2072) to hwtable

Message ID 20241205224917.7104-1-xose.vazquez@gmail.com (mailing list archive)
State Not Applicable, archived
Delegated to: Benjamin Marzinski
Headers show
Series [RFC] multipath-tools: add HPE MSA Gen7 (2070/2072) to hwtable | expand

Commit Message

Xose Vazquez Perez Dec. 5, 2024, 10:49 p.m. UTC
https://support.hpe.com/connect/s/product?kmpmoid=1014856412

Just guessing, confirmation from manufacturer is needed.

Cc: Jon Paul <Jon.Paul@hpe.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul, Jon (HPE Storage-Fort Collins) Dec. 5, 2024, 11:27 p.m. UTC | #1
Thanks Xose,

I had a lot of help finding the right contacts a few years ago to add MSA Gen6 you have solved that problem for me.

The updates you show below are correct and approved from the HPE MSA R&D team.

JP
Jon Paul
(970) 898-4375
Jon.Paul@hpe.com

-----Original Message-----
From: Xose Vazquez Perez <xose.vazquez@gmail.com> 
Sent: Thursday, December 5, 2024 3:49 PM
Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>; Paul, Jon (HPE Storage-Fort Collins) <jon.paul@hpe.com>; Martin Wilck <mwilck@suse.com>; Benjamin Marzinski <bmarzins@redhat.com>; Christophe Varoqui <christophe.varoqui@opensvc.com>; DM-DEVEL ML <dm-devel@lists.linux.dev>
Subject: [PATCH RFC] multipath-tools: add HPE MSA Gen7 (2070/2072) to hwtable

https://support.hpe.com/connect/s/product?kmpmoid=1014856412

Just guessing, confirmation from manufacturer is needed.

Cc: Jon Paul <Jon.Paul@hpe.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 32118339..543f0bc1 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -188,9 +188,9 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ALUA,
 	},
 	{
-		/* MSA 1040, 1050, 1060, 2040, 2050 and 2060 families */
+		/* MSA 1040, 1050, 1060, 2040, 2050, 2060 and 2070 families */
 		.vendor        = "(HP|HPE)",
-		.product       = "MSA [12]0[456]0 (SAN|SAS|FC|iSCSI)",
+		.product       = "MSA [12]0[4567]0 (SAN|SAS|FC|iSCSI)",
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 18,
--
2.47.1
Benjamin Marzinski Dec. 11, 2024, 11:16 p.m. UTC | #2
On Thu, Dec 05, 2024 at 11:49:16PM +0100, Xose Vazquez Perez wrote:
> https://support.hpe.com/connect/s/product?kmpmoid=1014856412
> 
> Just guessing, confirmation from manufacturer is needed.
> 
> Cc: Jon Paul <Jon.Paul@hpe.com>
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> ---
>  libmultipath/hwtable.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 32118339..543f0bc1 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -188,9 +188,9 @@ static struct hwentry default_hw[] = {
>  		.prio_name     = PRIO_ALUA,
>  	},
>  	{
> -		/* MSA 1040, 1050, 1060, 2040, 2050 and 2060 families */
> +		/* MSA 1040, 1050, 1060, 2040, 2050, 2060 and 2070 families */
>  		.vendor        = "(HP|HPE)",
> -		.product       = "MSA [12]0[456]0 (SAN|SAS|FC|iSCSI)",
> +		.product       = "MSA [12]0[4567]0 (SAN|SAS|FC|iSCSI)",
>  		.pgpolicy      = GROUP_BY_PRIO,
>  		.pgfailback    = -FAILBACK_IMMEDIATE,
>  		.no_path_retry = 18,
> -- 
> 2.47.1
Martin Wilck Dec. 12, 2024, 4:46 p.m. UTC | #3
On Wed, 2024-12-11 at 18:16 -0500, Benjamin Marzinski wrote:
> On Thu, Dec 05, 2024 at 11:49:16PM +0100, Xose Vazquez Perez wrote:
> > https://support.hpe.com/connect/s/product?kmpmoid=1014856412
> > 
> > Just guessing, confirmation from manufacturer is needed.
> > 
> > Cc: Jon Paul <Jon.Paul@hpe.com>
> > Cc: Martin Wilck <mwilck@suse.com>
> > Cc: Benjamin Marzinski <bmarzins@redhat.com>
> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> > Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> 
> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

I've already pushed this patch the "queue" branch, as Jon had ack'd it.

Martin
diff mbox series

Patch

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 32118339..543f0bc1 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -188,9 +188,9 @@  static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ALUA,
 	},
 	{
-		/* MSA 1040, 1050, 1060, 2040, 2050 and 2060 families */
+		/* MSA 1040, 1050, 1060, 2040, 2050, 2060 and 2070 families */
 		.vendor        = "(HP|HPE)",
-		.product       = "MSA [12]0[456]0 (SAN|SAS|FC|iSCSI)",
+		.product       = "MSA [12]0[4567]0 (SAN|SAS|FC|iSCSI)",
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 18,