| Message ID | 20241205213315.3073207-1-karprzy7@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: tps25990: Fix unreachable code in tps25990_read_word_data | expand |
On Thu, Dec 05, 2024 at 10:33:15PM +0100, Karol Przybylski wrote: > The tps25990_read_word_data function contains a block of unreachable code caused by the syntactic structure in the PMBUS_VIRT_READ_IIN_MAX case. > > Specifically, the return TPS25990_READ_IIN_PEAK; statement immediately exits the function, making the next lines unreachable. > > This patch removes the return statement, leaving the expected handling. > > Discovered in coverity: CID 1602227 > > Signed-off-by: Karol Przybylski <karprzy7@gmail.com> Thanks a log for the patch. I squashed it into the patch introducing the problem. Please note that the above commit message is missing line breaks. Thanks, Guenter
diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c index cc0f5c7ce..0d2655e69 100644 --- a/drivers/hwmon/pmbus/tps25990.c +++ b/drivers/hwmon/pmbus/tps25990.c @@ -130,7 +130,6 @@ static int tps25990_read_word_data(struct i2c_client *client, break; case PMBUS_VIRT_READ_IIN_MAX: - return TPS25990_READ_IIN_PEAK; ret = pmbus_read_word_data(client, page, phase, TPS25990_READ_IIN_PEAK); break;
The tps25990_read_word_data function contains a block of unreachable code caused by the syntactic structure in the PMBUS_VIRT_READ_IIN_MAX case. Specifically, the return TPS25990_READ_IIN_PEAK; statement immediately exits the function, making the next lines unreachable. This patch removes the return statement, leaving the expected handling. Discovered in coverity: CID 1602227 Signed-off-by: Karol Przybylski <karprzy7@gmail.com> --- drivers/hwmon/pmbus/tps25990.c | 1 - 1 file changed, 1 deletion(-)