[net,0/3] selftests: mlxsw: Add few fixes for sharedbuffer test

Message

Petr Machata Dec. 5, 2024, 4:35 p.m. UTC

Danielle Ratson writes:

Currently, the sharedbuffer test fails sometimes because it is reading a
maximum occupancy that is larger than expected on some different cases.

This is happening because the test assumes that the packet it is sending
is the only packet being passed to the device.

In addition, some duplications on one hand, and redundant test cases on
the other hand, were found in the test.

Add egress filters on h1 and h2 that will guarantee that the packets in
the buffer are sent in the test, and remove the redundant test cases.

Danielle Ratson (3):
  selftests: mlxsw: sharedbuffer: Remove h1 ingress test case
  selftests: mlxsw: sharedbuffer: Remove duplicate test cases
  selftests: mlxsw: sharedbuffer: Ensure no extra packets are counted

 .../drivers/net/mlxsw/sharedbuffer.sh         | 55 ++++++++++++++-----
 1 file changed, 40 insertions(+), 15 deletions(-)

Comments

[e-mail] Dec. 7, 2024, 1:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Thu, 5 Dec 2024 17:35:58 +0100 you wrote:
> Danielle Ratson writes:
> 
> Currently, the sharedbuffer test fails sometimes because it is reading a
> maximum occupancy that is larger than expected on some different cases.
> 
> This is happening because the test assumes that the packet it is sending
> is the only packet being passed to the device.
> 
> [...]

Here is the summary with links:
  - [net,1/3] selftests: mlxsw: sharedbuffer: Remove h1 ingress test case
    https://git.kernel.org/netdev/net/c/cf3515c55690
  - [net,2/3] selftests: mlxsw: sharedbuffer: Remove duplicate test cases
    https://git.kernel.org/netdev/net/c/6c46ad4d1bb2
  - [net,3/3] selftests: mlxsw: sharedbuffer: Ensure no extra packets are counted
    https://git.kernel.org/netdev/net/c/5f2c7ab15fd8

You are awesome, thank you!