diff mbox series

[1/9] target/arm: Introduce fpst alias for helper.h

Message ID 20241206031224.78525-2-richard.henderson@linaro.org (mailing list archive)
State New
Headers show
Series target/arm: Helper type cleanups | expand

Commit Message

Richard Henderson Dec. 6, 2024, 3:12 a.m. UTC
This allows us to declare that the helper requires
a float_status pointer and not a generic void pointer.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/helper.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Philippe Mathieu-Daudé Dec. 6, 2024, 8:35 a.m. UTC | #1
On 6/12/24 04:12, Richard Henderson wrote:
> This allows us to declare that the helper requires
> a float_status pointer and not a generic void pointer.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/arm/helper.h | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Richard Henderson Dec. 7, 2024, 9:56 p.m. UTC | #2
On 12/5/24 21:12, Richard Henderson wrote:
> This allows us to declare that the helper requires
> a float_status pointer and not a generic void pointer.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/arm/helper.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/target/arm/helper.h b/target/arm/helper.h
> index 9919b1367b..cb722c491b 100644
> --- a/target/arm/helper.h
> +++ b/target/arm/helper.h
> @@ -1,3 +1,7 @@
> +#define dh_alias_fpst ptr
> +#define dh_ctype_fpst float_status *
> +#define dh_typecode_fpst dh_typecode_ptr
> +
>   DEF_HELPER_FLAGS_1(sxtb16, TCG_CALL_NO_RWG_SE, i32, i32)
>   DEF_HELPER_FLAGS_1(uxtb16, TCG_CALL_NO_RWG_SE, i32, i32)
>   

This should go into include/exec/helper-head.h for use by all targets.


r~
Philippe Mathieu-Daudé Dec. 8, 2024, 5:51 p.m. UTC | #3
On 7/12/24 22:56, Richard Henderson wrote:
> On 12/5/24 21:12, Richard Henderson wrote:
>> This allows us to declare that the helper requires
>> a float_status pointer and not a generic void pointer.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   target/arm/helper.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/target/arm/helper.h b/target/arm/helper.h
>> index 9919b1367b..cb722c491b 100644
>> --- a/target/arm/helper.h
>> +++ b/target/arm/helper.h
>> @@ -1,3 +1,7 @@
>> +#define dh_alias_fpst ptr
>> +#define dh_ctype_fpst float_status *
>> +#define dh_typecode_fpst dh_typecode_ptr
>> +
>>   DEF_HELPER_FLAGS_1(sxtb16, TCG_CALL_NO_RWG_SE, i32, i32)
>>   DEF_HELPER_FLAGS_1(uxtb16, TCG_CALL_NO_RWG_SE, i32, i32)
> 
> This should go into include/exec/helper-head.h for use by all targets.

Oh, indeed. R-b stands.
diff mbox series

Patch

diff --git a/target/arm/helper.h b/target/arm/helper.h
index 9919b1367b..cb722c491b 100644
--- a/target/arm/helper.h
+++ b/target/arm/helper.h
@@ -1,3 +1,7 @@ 
+#define dh_alias_fpst ptr
+#define dh_ctype_fpst float_status *
+#define dh_typecode_fpst dh_typecode_ptr
+
 DEF_HELPER_FLAGS_1(sxtb16, TCG_CALL_NO_RWG_SE, i32, i32)
 DEF_HELPER_FLAGS_1(uxtb16, TCG_CALL_NO_RWG_SE, i32, i32)