| Message ID | 20241209025242.2995-1-zhujun2@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] zonefs: Fix the wrong format specifier | expand |
On 12/9/24 11:52, Zhu Jun wrote: > Change f to unsigned int to resolve the mismatch in format specifiers for > snprintf(), where %u should be used for unsigned integers instead of %d > > Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> The patch title is now wrong... And you forgot to add a Fixes tag. Will fix that when applying. Thanks. > --- > Changes: > v2: > A better fix is to make f "unsigned int" as that is consistent with > g_nr_zones and the fact that up to "unsigned int" total number of zones are > allowed for a zoned device. > > Can you send a v2 ? Also please add a Fixes tag. > > fs/zonefs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c > index faf1eb878..695da258a 100644 > --- a/fs/zonefs/super.c > +++ b/fs/zonefs/super.c > @@ -791,7 +791,7 @@ static int zonefs_readdir_zgroup(struct file *file, > int fname_len; > char *fname; > ino_t ino; > - int f; > + unsigned int f; > > /* > * The size of zone group directories is equal to the number
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index faf1eb878..695da258a 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -791,7 +791,7 @@ static int zonefs_readdir_zgroup(struct file *file, int fname_len; char *fname; ino_t ino; - int f; + unsigned int f; /* * The size of zone group directories is equal to the number
Change f to unsigned int to resolve the mismatch in format specifiers for snprintf(), where %u should be used for unsigned integers instead of %d Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> --- Changes: v2: A better fix is to make f "unsigned int" as that is consistent with g_nr_zones and the fact that up to "unsigned int" total number of zones are allowed for a zoned device. Can you send a v2 ? Also please add a Fixes tag. fs/zonefs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)