mbox series

[v2,0/2] Additional miscdevice fops parameters

Message ID 20241209-miscdevice-file-param-v2-0-83ece27e9ff6@google.com (mailing list archive)
Headers show
Series Additional miscdevice fops parameters | expand

Message

Alice Ryhl Dec. 9, 2024, 7:27 a.m. UTC
This could not land with the base miscdevice abstractions due to the
dependency on File.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
Changes in v2:
- Access the `struct miscdevice` from fops->open().
- Link to v1: https://lore.kernel.org/r/20241203-miscdevice-file-param-v1-1-1d6622978480@google.com

---
Alice Ryhl (2):
      rust: miscdevice: access file in fops
      rust: miscdevice: access the `struct miscdevice` from fops->open()

 rust/kernel/miscdevice.rs | 44 ++++++++++++++++++++++++++++++++++++++------
 1 file changed, 38 insertions(+), 6 deletions(-)
---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241203-miscdevice-file-param-5df7f75861da

Best regards,

Comments

Greg Kroah-Hartman Dec. 9, 2024, 8:43 a.m. UTC | #1
On Mon, Dec 09, 2024 at 07:27:45AM +0000, Alice Ryhl wrote:
> This could not land with the base miscdevice abstractions due to the
> dependency on File.

So these should go through my char/misc branch now, right?

> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

No need to sign off on patch 0/X :)

thanks,

greg k-h
Miguel Ojeda Dec. 9, 2024, 10:19 a.m. UTC | #2
On Mon, Dec 9, 2024 at 9:43 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> So these should go through my char/misc branch now, right?

That would be ideal, yeah -- thanks!

Cheers,
Miguel
Alice Ryhl Dec. 9, 2024, 10:44 a.m. UTC | #3
On Mon, Dec 9, 2024 at 9:43 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Dec 09, 2024 at 07:27:45AM +0000, Alice Ryhl wrote:
> > This could not land with the base miscdevice abstractions due to the
> > dependency on File.
>
> So these should go through my char/misc branch now, right?

Yes, that would be great, thanks!

> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>
> No need to sign off on patch 0/X :)

That's just the default when using b4 to send series.

Alice
Konstantin Ryabitsev Dec. 9, 2024, 8:06 p.m. UTC | #4
On Mon, Dec 09, 2024 at 11:44:04AM +0100, Alice Ryhl wrote:
> > > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> >
> > No need to sign off on patch 0/X :)
> 
> That's just the default when using b4 to send series.

Some subsystems use cover letters as merge commit messages, which is why we
put the Signed-off-by there by default. Those subsystems that don't use this
workflow can just ignore it (or switch to using the "b4 shazam -M" workflow
themselves, which has its perks).

-K