| Message ID | 95c0fa3fc2969daf3b6bc1f007733f11b715a465.1733561462.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Prepare GHES driver to support error injection | expand |
On Sat, 7 Dec 2024 09:54:14 +0100 Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > The 'physical_address' value is a faulty page. As such, 0 is > as valid as any other value. Still not sure on what faulty pages are :) Given I tagged previous (after you'd sent this) Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > hw/acpi/ghes.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index edc74c38bf8a..a3dffd78b012 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -400,10 +400,6 @@ int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address) > > start_addr = le64_to_cpu(ags->ghes_addr_le); > > - if (!physical_address) { > - return -1; > - } > - > start_addr += source_id * sizeof(uint64_t); > > cpu_physical_memory_read(start_addr, &error_block_addr,
Em Mon, 9 Dec 2024 11:36:40 +0000 Jonathan Cameron <Jonathan.Cameron@huawei.com> escreveu: > On Sat, 7 Dec 2024 09:54:14 +0100 > Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > > The 'physical_address' value is a faulty page. As such, 0 is > > as valid as any other value. > Still not sure on what faulty pages are :) > > Given I tagged previous (after you'd sent this) > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> It seems I forgot adding this tag, from Igor's review, as per: https://lore.kernel.org/qemu-devel/20241204141246.37a7cb9d@imammedo.users.ipa.redhat.com/ This patch was reviwed by Igor already, so: Reviewed-by: Igor Mammedov <imammedo@redhat.com> > > > > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > --- > > hw/acpi/ghes.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > > index edc74c38bf8a..a3dffd78b012 100644 > > --- a/hw/acpi/ghes.c > > +++ b/hw/acpi/ghes.c > > @@ -400,10 +400,6 @@ int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address) > > > > start_addr = le64_to_cpu(ags->ghes_addr_le); > > > > - if (!physical_address) { > > - return -1; > > - } > > - > > start_addr += source_id * sizeof(uint64_t); > > > > cpu_physical_memory_read(start_addr, &error_block_addr, > Thanks, Mauro
On Mon, 9 Dec 2024 11:36:40 +0000 Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > On Sat, 7 Dec 2024 09:54:14 +0100 > Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > > The 'physical_address' value is a faulty page. As such, 0 is > > as valid as any other value. > Still not sure on what faulty pages are :) s/page/address/ probably would make it a bit more clear > > Given I tagged previous (after you'd sent this) > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > --- > > hw/acpi/ghes.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > > index edc74c38bf8a..a3dffd78b012 100644 > > --- a/hw/acpi/ghes.c > > +++ b/hw/acpi/ghes.c > > @@ -400,10 +400,6 @@ int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address) > > > > start_addr = le64_to_cpu(ags->ghes_addr_le); > > > > - if (!physical_address) { > > - return -1; > > - } > > - > > start_addr += source_id * sizeof(uint64_t); > > > > cpu_physical_memory_read(start_addr, &error_block_addr, >
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index edc74c38bf8a..a3dffd78b012 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -400,10 +400,6 @@ int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address) start_addr = le64_to_cpu(ags->ghes_addr_le); - if (!physical_address) { - return -1; - } - start_addr += source_id * sizeof(uint64_t); cpu_physical_memory_read(start_addr, &error_block_addr,
The 'physical_address' value is a faulty page. As such, 0 is as valid as any other value. Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- hw/acpi/ghes.c | 4 ---- 1 file changed, 4 deletions(-)