common: loop device work on zoned file systems

Commit Message

Christoph Hellwig Dec. 10, 2024, 7:03 a.m. UTC

Remove the call to _require_non_zoned_device from _require_loop because
there is nothing that prevents loop device to work on file systems on
zoned devices.  But loop devices are not supported directly on top of
zoned block devices, so add a _require_non_zoned_device to generic/563
to not run that test on zoned block devices.

Signed-off-by: Christoph Hellwig <[e-mail]>
---
 common/rc         | 3 ---
 tests/generic/563 | 4 ++++
 2 files changed, 4 insertions(+), 3 deletions(-)

Comments

Johannes Thumshirn Dec. 10, 2024, 7:10 a.m. UTC | #1

Looks good,
Reviewed-by: Johannes Thumshirn <[e-mail]>

Patch

diff --git a/common/rc b/common/rc
index b3ea55a7fb5c..5ef5038a6d23 100644
--- a/common/rc
+++ b/common/rc
@@ -2269,9 +2269,6 @@  _require_loop()
     else
 	_notrun "This test requires loopback device support"
     fi
-
-    # loop device does not handle zone information
-    _require_non_zoned_device ${TEST_DEV}
 }
 
 # this test requires kernel support for a secondary filesystem
diff --git a/tests/generic/563 b/tests/generic/563
index 2056470df825..95a928fba562 100755
--- a/tests/generic/563
+++ b/tests/generic/563
@@ -38,6 +38,10 @@  _require_loop
 # cgroup v2 writeback is only support on block devices so far
 _require_block_device $SCRATCH_DEV
 
+# this test creates a loop device on the scratch block device, which is not
+# supported on zoned devices
+_require_non_zoned_device ${SCRATCH_DEV}
+
 cgdir=$CGROUP2_PATH
 iosize=$((1024 * 1024 * 8))