| Message ID | 20241205123720.3278727-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/pps: include panel power cycle delay in debugfs | expand |
Dear Jani, Thank you for the patch. Am 05.12.24 um 13:37 schrieb Jani Nikula: > The debugfs contains all the other timings except panel power cycle > delay. Add it for completeness. For the record, here is the output from the Dell XPS 13 9360, and in case you want to add it to the commit message. $ sudo more /sys/kernel/debug/dri/0000:00:02.0/eDP-1/i915_panel_timings Panel power up delay: 200 Panel power down delay: 50 Panel power cycle delay: 600 Backlight on delay: 1 Backlight off delay: 200 > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_pps.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c > index 7784b3b760db..e55c84685521 100644 > --- a/drivers/gpu/drm/i915/display/intel_pps.c > +++ b/drivers/gpu/drm/i915/display/intel_pps.c > @@ -1819,6 +1819,8 @@ static int intel_pps_show(struct seq_file *m, void *data) > intel_dp->pps.panel_power_up_delay); > seq_printf(m, "Panel power down delay: %d\n", > intel_dp->pps.panel_power_down_delay); > + seq_printf(m, "Panel power cycle delay: %d\n", > + intel_dp->pps.panel_power_cycle_delay); > seq_printf(m, "Backlight on delay: %d\n", > intel_dp->pps.backlight_on_delay); > seq_printf(m, "Backlight off delay: %d\n", Tested-by: Paul Menzel <pmenzel@molgen.mpg.de> # Dell XPS 13 9360 Kind regards, Paul
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani > Nikula > Sent: Thursday, December 5, 2024 6:07 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com> > Subject: [PATCH] drm/i915/pps: include panel power cycle delay in debugfs > > The debugfs contains all the other timings except panel power cycle delay. > Add it for completeness. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> LGTM. Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> > --- > drivers/gpu/drm/i915/display/intel_pps.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_pps.c > b/drivers/gpu/drm/i915/display/intel_pps.c > index 7784b3b760db..e55c84685521 100644 > --- a/drivers/gpu/drm/i915/display/intel_pps.c > +++ b/drivers/gpu/drm/i915/display/intel_pps.c > @@ -1819,6 +1819,8 @@ static int intel_pps_show(struct seq_file *m, void > *data) > intel_dp->pps.panel_power_up_delay); > seq_printf(m, "Panel power down delay: %d\n", > intel_dp->pps.panel_power_down_delay); > + seq_printf(m, "Panel power cycle delay: %d\n", > + intel_dp->pps.panel_power_cycle_delay); > seq_printf(m, "Backlight on delay: %d\n", > intel_dp->pps.backlight_on_delay); > seq_printf(m, "Backlight off delay: %d\n", > -- > 2.39.5
On Mon, 09 Dec 2024, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote: >> -----Original Message----- >> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani >> Nikula >> Sent: Thursday, December 5, 2024 6:07 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani <jani.nikula@intel.com> >> Subject: [PATCH] drm/i915/pps: include panel power cycle delay in debugfs >> >> The debugfs contains all the other timings except panel power cycle delay. >> Add it for completeness. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > LGTM. > > Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> Thanks, pushed to din. BR, Jani. > > >> --- >> drivers/gpu/drm/i915/display/intel_pps.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c >> b/drivers/gpu/drm/i915/display/intel_pps.c >> index 7784b3b760db..e55c84685521 100644 >> --- a/drivers/gpu/drm/i915/display/intel_pps.c >> +++ b/drivers/gpu/drm/i915/display/intel_pps.c >> @@ -1819,6 +1819,8 @@ static int intel_pps_show(struct seq_file *m, void >> *data) >> intel_dp->pps.panel_power_up_delay); >> seq_printf(m, "Panel power down delay: %d\n", >> intel_dp->pps.panel_power_down_delay); >> + seq_printf(m, "Panel power cycle delay: %d\n", >> + intel_dp->pps.panel_power_cycle_delay); >> seq_printf(m, "Backlight on delay: %d\n", >> intel_dp->pps.backlight_on_delay); >> seq_printf(m, "Backlight off delay: %d\n", >> -- >> 2.39.5 >
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c index 7784b3b760db..e55c84685521 100644 --- a/drivers/gpu/drm/i915/display/intel_pps.c +++ b/drivers/gpu/drm/i915/display/intel_pps.c @@ -1819,6 +1819,8 @@ static int intel_pps_show(struct seq_file *m, void *data) intel_dp->pps.panel_power_up_delay); seq_printf(m, "Panel power down delay: %d\n", intel_dp->pps.panel_power_down_delay); + seq_printf(m, "Panel power cycle delay: %d\n", + intel_dp->pps.panel_power_cycle_delay); seq_printf(m, "Backlight on delay: %d\n", intel_dp->pps.backlight_on_delay); seq_printf(m, "Backlight off delay: %d\n",
The debugfs contains all the other timings except panel power cycle delay. Add it for completeness. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_pps.c | 2 ++ 1 file changed, 2 insertions(+)