mbox series

[0/5] arm64: renesas: Add R8A779G3 White Hawk Single support

Message ID cover.1733156661.git.geert+renesas@glider.be (mailing list archive)
Headers show
Series arm64: renesas: Add R8A779G3 White Hawk Single support | expand

Message

Geert Uytterhoeven Dec. 2, 2024, 4:30 p.m. UTC
Hi all,

This patch series adds support for the Renesas R-Car V4H ES3.0 (R8A779G3)
SoC on the Renesas White Hawk Single board.  R-Car V4H ES3.0 (R8A779G3)
is an updated version of R-Car V4H (R8A779G0).

I intend to queue these in renesas-devel for v6.14.
Thanks for your comments!

Geert Uytterhoeven (5):
  dt-bindings: soc: renesas: Move R8A779G0 White Hawk up
  dt-bindings: soc: renesas: Document R8A779G3 White Hawk Single
  arm64: dts: renesas: Factor out White Hawk Single board support
  arm64: dts: renesas: Add R8A779G3 SoC support
  arm64: dts: renesas: r8a779g3: Add White Hawk Single support

 .../bindings/soc/renesas/renesas.yaml         | 16 ++---
 arch/arm64/boot/dts/renesas/Makefile          |  2 +
 .../renesas/r8a779g2-white-hawk-single.dts    | 62 +------------------
 .../renesas/r8a779g3-white-hawk-single.dts    | 16 +++++
 arch/arm64/boot/dts/renesas/r8a779g3.dtsi     | 12 ++++
 ...hawk-single.dts => white-hawk-single.dtsi} | 11 ++--
 6 files changed, 44 insertions(+), 75 deletions(-)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779g3-white-hawk-single.dts
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779g3.dtsi
 copy arch/arm64/boot/dts/renesas/{r8a779g2-white-hawk-single.dts => white-hawk-single.dtsi} (78%)

Comments

Kuninori Morimoto Dec. 4, 2024, 12:55 a.m. UTC | #1
Hi Geert

> This patch series adds support for the Renesas R-Car V4H ES3.0 (R8A779G3)
> SoC on the Renesas White Hawk Single board.  R-Car V4H ES3.0 (R8A779G3)
> is an updated version of R-Car V4H (R8A779G0).
> 
> I intend to queue these in renesas-devel for v6.14.
> Thanks for your comments!

Thank you for the patch-set. For all patches

Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

But small nitpick is that R8A779G2 is not only for ES2.0 but for ES2.x



Thank you for your help !!

Best regards
---
Kuninori Morimoto
Geert Uytterhoeven Dec. 5, 2024, 9:07 a.m. UTC | #2
Hi Morimoto-san,

On Wed, Dec 4, 2024 at 1:56 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > This patch series adds support for the Renesas R-Car V4H ES3.0 (R8A779G3)
> > SoC on the Renesas White Hawk Single board.  R-Car V4H ES3.0 (R8A779G3)
> > is an updated version of R-Car V4H (R8A779G0).
> >
> > I intend to queue these in renesas-devel for v6.14.
> > Thanks for your comments!
>
> Thank you for the patch-set. For all patches
>
> Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> But small nitpick is that R8A779G2 is not only for ES2.0 but for ES2.x

I didn't add any occurrences of "ES2.0" in this series ;-)

I did consider adding comments to the SoC-specific compatible values
in Documentation/devicetree/bindings/soc/renesas/renesas.yaml

-              - renesas,r8a779g2
-              - renesas,r8a779g3
+              - renesas,r8a779g2 # ES2.x
+              - renesas,r8a779g3 # ES3.0

but decided against doing so, as "ES3.0" would become stale as soon
as Renesas releases "ES3.1". Alternatively, I could use "ES3.x"
immediately.

What do you think?
Thanks!

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Dec. 5, 2024, 11:18 p.m. UTC | #3
Hi Geert

> > But small nitpick is that R8A779G2 is not only for ES2.0 but for ES2.x
> 
> I didn't add any occurrences of "ES2.0" in this series ;-)

Almost, but we can see ;P

	[PATCH 5/5] arm64: dts: renesas: r8a779g3: Add White Hawk Single support
	...
	For now, there are no visible differences compared to the variant
=>	equipped with an R-Car V4H ES2.0 (R8A779G2) SoC.

> -              - renesas,r8a779g2
> -              - renesas,r8a779g3
> +              - renesas,r8a779g2 # ES2.x
> +              - renesas,r8a779g3 # ES3.0
> 
> but decided against doing so, as "ES3.0" would become stale as soon
> as Renesas releases "ES3.1". Alternatively, I could use "ES3.x"
> immediately.

Yeah, maybe, but will check.
Please wait.
Thank you for your help !!

Best regards
---
Kuninori Morimoto
Kuninori Morimoto Dec. 9, 2024, 7 a.m. UTC | #4
Hi Geert, again

> > -              - renesas,r8a779g2
> > -              - renesas,r8a779g3
> > +              - renesas,r8a779g2 # ES2.x
> > +              - renesas,r8a779g3 # ES3.0
> > 
> > but decided against doing so, as "ES3.0" would become stale as soon
> > as Renesas releases "ES3.1". Alternatively, I could use "ES3.x"
> > immediately.

It seems using "ES3.x" is a good idea.

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Geert Uytterhoeven Dec. 10, 2024, 10:04 a.m. UTC | #5
Hi Morimoto-san,

On Mon, Dec 9, 2024 at 8:00 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > > -              - renesas,r8a779g2
> > > -              - renesas,r8a779g3
> > > +              - renesas,r8a779g2 # ES2.x
> > > +              - renesas,r8a779g3 # ES3.0
> > >
> > > but decided against doing so, as "ES3.0" would become stale as soon
> > > as Renesas releases "ES3.1". Alternatively, I could use "ES3.x"
> > > immediately.
>
> It seems using "ES3.x" is a good idea.

Thanks for checking, I'll add these comments while applying.

Gr{oetje,eeting}s,

                        Geert