mbox series

[v2,0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs

Message ID 20241209175751.287738-1-mlevitsk@redhat.com (mailing list archive)
Headers show
Series MANA: Fix few memory leaks in mana_gd_setup_irqs | expand

Message

Maxim Levitsky Dec. 9, 2024, 5:57 p.m. UTC
Fix 2 minor memory leaks in the mana driver,
introduced by commit

8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")

Best regards,
	Maxim Levitsky

Maxim Levitsky (2):
  net: mana: Fix memory leak in mana_gd_setup_irqs
  net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs

 drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Michal Swiatkowski Dec. 10, 2024, 6:23 a.m. UTC | #1
On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
> 
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> 
> Best regards,
> 	Maxim Levitsky
> 

For next time please add a changleog, like here for example [1].
It is helpfull for the reviewers.

[1] https://lore.kernel.org/netdev/20241204140821.1858263-1-saikrishnag@marvell.com/T/#m5fc2fa8b1d2bd1b47cf7ccacd4031d1aa1aa8c2c

Thanks

> Maxim Levitsky (2):
>   net: mana: Fix memory leak in mana_gd_setup_irqs
>   net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
> 
>  drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.3
> 
>
Saurabh Singh Sengar Dec. 10, 2024, 10:24 a.m. UTC | #2
On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
> 
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> 
> Best regards,
> 	Maxim Levitsky
> 
> Maxim Levitsky (2):
>   net: mana: Fix memory leak in mana_gd_setup_irqs
>   net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
> 
>  drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.3
> 
> 

Thanks for fixing this, for the series
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>

could have been a single patch, though
Yury Norov Dec. 11, 2024, 6:34 p.m. UTC | #3
On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
> 
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")

Reviewed-by: Yury Norov <yury.norov@gmail.com>

> 
> Best regards,
> 	Maxim Levitsky
> 
> Maxim Levitsky (2):
>   net: mana: Fix memory leak in mana_gd_setup_irqs
>   net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
> 
>  drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.3
>
patchwork-bot+netdevbpf@kernel.org Dec. 12, 2024, 4:30 a.m. UTC | #4
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  9 Dec 2024 12:57:49 -0500 you wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
> 
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> 
> Best regards,
> 	Maxim Levitsky
> 
> [...]

Here is the summary with links:
  - [v2,1/2] net: mana: Fix memory leak in mana_gd_setup_irqs
    https://git.kernel.org/netdev/net/c/bb1e3eb57d2c
  - [v2,2/2] net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
    https://git.kernel.org/netdev/net/c/9a5beb6ca630

You are awesome, thank you!