[v3,0/2] platform/x86: Vexia EDU ATLA 10 pwrsrc and battery support

Message

Hans de Goede Dec. 4, 2024, 7:34 p.m. UTC

Hi All,

Here is v3 of my series to add support for having the bytcrc_pwrsrc driver
register a power_supply class device and adding a new driver for battery
monitoring using the Vexia EDU ATLA 10 EC.

Changes in v3:
- Use I2C_SMBUS_BLOCK_MAX instead of hardcoding 32 bytes as bufsize
- Add UPDATE_INTERVAL_JIFFIES define

Changes in v2:
- Makefile tweaks
- postfix variable/define names with units (e.g. _mV / _mAh)
- Replace i2c_smbus_read_i2c_block_data() with i2c_smbus_read_block_data()
  which takes care of the length byte prefixing the buffer for us
- Address other small review remarks

Regards,

Hans


Hans de Goede (2):
  platform/x86/intel: bytcrc_pwrsrc: Optionally register a power_supply
    dev
  platform/x86: x86-android-tablets: Add Vexia EDU ATLA 10 EC battery
    driver

 drivers/platform/x86/intel/bytcrc_pwrsrc.c    |  79 +++++-
 .../platform/x86/x86-android-tablets/Makefile |   2 +-
 .../x86/x86-android-tablets/vexia_atla10_ec.c | 261 ++++++++++++++++++
 3 files changed, 339 insertions(+), 3 deletions(-)
 create mode 100644 drivers/platform/x86/x86-android-tablets/vexia_atla10_ec.c

Comments

Ilpo Järvinen Dec. 10, 2024, 2:03 p.m. UTC | #1

On Wed, 04 Dec 2024 20:34:40 +0100, Hans de Goede wrote:

> Here is v3 of my series to add support for having the bytcrc_pwrsrc driver
> register a power_supply class device and adding a new driver for battery
> monitoring using the Vexia EDU ATLA 10 EC.
> 
> Changes in v3:
> - Use I2C_SMBUS_BLOCK_MAX instead of hardcoding 32 bytes as bufsize
> - Add UPDATE_INTERVAL_JIFFIES define
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/2] platform/x86/intel: bytcrc_pwrsrc: Optionally register a power_supply dev
      commit: 0130ec83c5535b034a96284eb9f31b3b5373d207
[2/2] platform/x86: x86-android-tablets: Add Vexia EDU ATLA 10 EC battery driver
      commit: c78dd25138d104f94ddeab5248a5efe4504f205e

--
 i.