| Message ID | 20241212004727.2903846-1-alexey.klimov@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | qrb4210-rb2: add wsa audio playback and capture support | expand |
On Thu, Dec 12, 2024 at 12:47:13AM +0000, Alexey Klimov wrote: > Issues with distorted sound and unstable volume on playback were resolved > and this patchset also includes support for onboard DMIC and thus > capturing feature. > > This implements the playback via the following path: > RX1 from DSP is connected to rxmacro which communicates with wcd codec > using soundwire. This goes into AUX input of wcd. > wcd codec outputs analog audio into wsa8815 amplifier. > Capturing works through vamacro using one onboard DMIC which is > directly connected to vamacro codec. > > Special thanks to Srini. Without his help and support this patchset > wouldn't be here. > > Previous version: > https://lore.kernel.org/linux-sound/20241101053154.497550-1-alexey.klimov@linaro.org/ > Please start using b4. b4 diff '20241212004727.2903846-2-alexey.klimov@linaro.org' Checking for older revisions Grabbing search results from lore.kernel.org Nothing matching that query. --- Analyzing 17 messages in the thread Could not find lower series to compare against. > Changes since v2: > > -- forcing single channel output for RX_1 channel is moved into drv variant; > -- added capture feature support hence some new patches and > updates to pins description; > -- sorted headers in wsa881x-i2c driver, removed excessive ones; > -- removed of_gpio.h as suggested by Rob; > -- removed wrong bindings and updated already existing > qcom,wsa881x.yaml as suggested by Krzysztof; > -- removed unused pins state description as suggested by Krzysztof; > -- reworked wsa881x-i2c driver > (initialisation, pm, consts, some functions, etc); > -- usage of devm_kmemdup() in wsa881x-i2c probe() as a hint from Krzysztof; > -- updated commit messages where required; > -- not using i2c gpio bit-banging for wsa881x i2c; > -- made dtbs_check and dt_binding_check happy. > > > This series depends on: > -- HDMI audio playback > https://lore.kernel.org/linux-arm-msm/20241204140027.2198763-1-alexey.klimov@linaro.org/ > -- and LPASS clock controller > https://lore.kernel.org/linux-clk/20241212002551.2902954-1-alexey.klimov@linaro.org/ This prevents merging anything to ASoC. I suggest decoupling dependencies or your patches will have to wait longer than needed. Best regards, Krzysztof
Issues with distorted sound and unstable volume on playback were resolved and this patchset also includes support for onboard DMIC and thus capturing feature. This implements the playback via the following path: RX1 from DSP is connected to rxmacro which communicates with wcd codec using soundwire. This goes into AUX input of wcd. wcd codec outputs analog audio into wsa8815 amplifier. Capturing works through vamacro using one onboard DMIC which is directly connected to vamacro codec. Special thanks to Srini. Without his help and support this patchset wouldn't be here. Previous version: https://lore.kernel.org/linux-sound/20241101053154.497550-1-alexey.klimov@linaro.org/ Changes since v2: -- forcing single channel output for RX_1 channel is moved into drv variant; -- added capture feature support hence some new patches and updates to pins description; -- sorted headers in wsa881x-i2c driver, removed excessive ones; -- removed of_gpio.h as suggested by Rob; -- removed wrong bindings and updated already existing qcom,wsa881x.yaml as suggested by Krzysztof; -- removed unused pins state description as suggested by Krzysztof; -- reworked wsa881x-i2c driver (initialisation, pm, consts, some functions, etc); -- usage of devm_kmemdup() in wsa881x-i2c probe() as a hint from Krzysztof; -- updated commit messages where required; -- not using i2c gpio bit-banging for wsa881x i2c; -- made dtbs_check and dt_binding_check happy. This series depends on: -- HDMI audio playback https://lore.kernel.org/linux-arm-msm/20241204140027.2198763-1-alexey.klimov@linaro.org/ -- and LPASS clock controller https://lore.kernel.org/linux-clk/20241212002551.2902954-1-alexey.klimov@linaro.org/ Alexey Klimov (14): ASoC: dt-bindings: qcom: Add SM6115 LPASS rxmacro and vamacro codecs ASoC: codecs: va-macro: add sm6115 compatible ASoC: codecs: lpass-rx-macro: add sm6115 compatible arm64: dts: qcom: sm6115: add LPASS devices arm64: dts: qcom: sm4250: add description of soundwire and dmic pins arm64: dts: qcom: qrb4210-rb2: add wcd937x codec support ASoC: codecs: wsa881x: split into common and soundwire drivers dt-bindings: arm: qcom-soc: extend pattern matching to support qcom,wsa881x ASoC: dt-bindings: qcom,wsa881x: extend description to analog mode arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier ASoC: codecs: add wsa881x-i2c amplifier codec driver arm64: dts: qcom: qrb4210-rb2: add WSA audio playback support arm64: dts: qcom: qrb4210-rb2: add VA capture support ASoC: qcom: sm8250: force single channel via RX_1 output for qrb4210 .../devicetree/bindings/arm/qcom-soc.yaml | 3 +- .../bindings/sound/qcom,lpass-rx-macro.yaml | 19 + .../bindings/sound/qcom,lpass-va-macro.yaml | 17 + .../bindings/sound/qcom,wsa881x.yaml | 75 +- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 126 +- arch/arm64/boot/dts/qcom/sm4250.dtsi | 62 + arch/arm64/boot/dts/qcom/sm6115.dtsi | 132 ++ sound/soc/codecs/Kconfig | 15 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/lpass-rx-macro.c | 4 +- sound/soc/codecs/lpass-va-macro.c | 1 + sound/soc/codecs/wsa881x-common.c | 123 ++ sound/soc/codecs/wsa881x-common.h | 426 ++++++ sound/soc/codecs/wsa881x-i2c.c | 1352 +++++++++++++++++ sound/soc/codecs/wsa881x.c | 493 +----- sound/soc/qcom/sm8250.c | 28 +- 16 files changed, 2384 insertions(+), 496 deletions(-) create mode 100644 sound/soc/codecs/wsa881x-common.c create mode 100644 sound/soc/codecs/wsa881x-common.h create mode 100644 sound/soc/codecs/wsa881x-i2c.c