| Message ID | 20241212004727.2903846-2-alexey.klimov@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | qrb4210-rb2: add wsa audio playback and capture support | expand |
On Thu, 12 Dec 2024 00:47:14 +0000, Alexey Klimov wrote: > Document compatibles for Qualcomm SM6115 SoC macro digital codecs > (RX and VA). > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> > --- > .../bindings/sound/qcom,lpass-rx-macro.yaml | 19 +++++++++++++++++++ > .../bindings/sound/qcom,lpass-va-macro.yaml | 17 +++++++++++++++++ > 2 files changed, 36 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.example.dtb: codec@3370000: clock-names:1: 'dcodec' was expected from schema $id: http://devicetree.org/schemas/sound/qcom,lpass-va-macro.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.example.dtb: codec@3370000: clock-names:2: 'npl' was expected from schema $id: http://devicetree.org/schemas/sound/qcom,lpass-va-macro.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241212004727.2903846-2-alexey.klimov@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Dec 12, 2024 at 12:47:14AM +0000, Alexey Klimov wrote: > Document compatibles for Qualcomm SM6115 SoC macro digital codecs > (RX and VA). > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> > --- Changelog does not mention anything about this file (or I missed it), b4 diff fails, so what happened here? > .../bindings/sound/qcom,lpass-rx-macro.yaml | 19 +++++++++++++++++++ > .../bindings/sound/qcom,lpass-va-macro.yaml | 17 +++++++++++++++++ > 2 files changed, 36 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml > index 92f95eb74b19..697c5591ae7c 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml > @@ -14,6 +14,7 @@ properties: > oneOf: > - enum: > - qcom,sc7280-lpass-rx-macro > + - qcom,sm6115-lpass-rx-macro > - qcom,sm8250-lpass-rx-macro > - qcom,sm8450-lpass-rx-macro > - qcom,sm8550-lpass-rx-macro > @@ -80,6 +81,24 @@ allOf: > - const: npl > - const: fsgen > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm6115-lpass-rx-macro > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 > + clock-names: > + items: > + - const: mclk > + - const: npl > + - const: dcodec > + - const: fsgen > + > - if: > properties: > compatible: > diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > index f41deaa6f4df..30a44b444f39 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > @@ -14,6 +14,7 @@ properties: > oneOf: > - enum: > - qcom,sc7280-lpass-va-macro > + - qcom,sm6115-lpass-va-macro > - qcom,sm8250-lpass-va-macro > - qcom,sm8450-lpass-va-macro > - qcom,sm8550-lpass-va-macro > @@ -83,6 +84,22 @@ allOf: > items: > - const: mclk > > + - if: > + properties: > + compatible: > + contains: > + const: qcom,sm8250-lpass-va-macro Wrong comaptible. Best regards, Krzysztof
On 12.12.2024 1:47 AM, Alexey Klimov wrote: > Document compatibles for Qualcomm SM6115 SoC macro digital codecs > (RX and VA). > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> > --- [...] > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > @@ -14,6 +14,7 @@ properties: > oneOf: > - enum: > - qcom,sc7280-lpass-va-macro > + - qcom,sm6115-lpass-va-macro > - qcom,sm8250-lpass-va-macro > - qcom,sm8450-lpass-va-macro > - qcom,sm8550-lpass-va-macro > @@ -83,6 +84,22 @@ allOf: > items: > - const: mclk > > + - if: > + properties: > + compatible: > + contains: > + const: qcom,sm8250-lpass-va-macro We all like pasta! Konrad
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml index 92f95eb74b19..697c5591ae7c 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml @@ -14,6 +14,7 @@ properties: oneOf: - enum: - qcom,sc7280-lpass-rx-macro + - qcom,sm6115-lpass-rx-macro - qcom,sm8250-lpass-rx-macro - qcom,sm8450-lpass-rx-macro - qcom,sm8550-lpass-rx-macro @@ -80,6 +81,24 @@ allOf: - const: npl - const: fsgen + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6115-lpass-rx-macro + then: + properties: + clocks: + minItems: 4 + maxItems: 4 + clock-names: + items: + - const: mclk + - const: npl + - const: dcodec + - const: fsgen + - if: properties: compatible: diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml index f41deaa6f4df..30a44b444f39 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml @@ -14,6 +14,7 @@ properties: oneOf: - enum: - qcom,sc7280-lpass-va-macro + - qcom,sm6115-lpass-va-macro - qcom,sm8250-lpass-va-macro - qcom,sm8450-lpass-va-macro - qcom,sm8550-lpass-va-macro @@ -83,6 +84,22 @@ allOf: items: - const: mclk + - if: + properties: + compatible: + contains: + const: qcom,sm8250-lpass-va-macro + then: + properties: + clocks: + minItems: 3 + maxItems: 3 + clock-names: + items: + - const: mclk + - const: dcodec + - const: npl + - if: properties: compatible:
Document compatibles for Qualcomm SM6115 SoC macro digital codecs (RX and VA). Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> --- .../bindings/sound/qcom,lpass-rx-macro.yaml | 19 +++++++++++++++++++ .../bindings/sound/qcom,lpass-va-macro.yaml | 17 +++++++++++++++++ 2 files changed, 36 insertions(+)