| Message ID | Z014ylYz_xrrgI4W@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] PCI: rockchip-ep: Fix error code in rockchip_pcie_ep_init_ob_mem() | expand |
On Mon, Dec 02, 2024 at 12:07:22PM +0300, Dan Carpenter wrote: > Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success. > > Fixes: 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > Reviewed-by: Damien Le Moal <dlemoal@kernel.org> > --- > v2: Update the git hash for the Fixes tag because the tree was rebased I guess. > > drivers/pci/controller/pcie-rockchip-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c > index 1064b7b06cef..34162ca14093 100644 > --- a/drivers/pci/controller/pcie-rockchip-ep.c > +++ b/drivers/pci/controller/pcie-rockchip-ep.c > @@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep) > SZ_1M); > if (!ep->irq_cpu_addr) { > dev_err(dev, "failed to reserve memory space for MSI\n"); > + err = -ENOMEM; > goto err_epc_mem_exit; > } > > -- > 2.45.2 >
On Mon, Dec 02, 2024 at 12:07:22PM +0300, Dan Carpenter wrote: > Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success. > > Fixes: 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > Reviewed-by: Damien Le Moal <dlemoal@kernel.org> > --- > v2: Update the git hash for the Fixes tag because the tree was rebased I guess. > > drivers/pci/controller/pcie-rockchip-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c > index 1064b7b06cef..34162ca14093 100644 > --- a/drivers/pci/controller/pcie-rockchip-ep.c > +++ b/drivers/pci/controller/pcie-rockchip-ep.c > @@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep) > SZ_1M); > if (!ep->irq_cpu_addr) { > dev_err(dev, "failed to reserve memory space for MSI\n"); > + err = -ENOMEM; > goto err_epc_mem_exit; > } > > -- > 2.45.2 > Reviewed-by: Niklas Cassel <cassel@kernel.org>
diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c index 1064b7b06cef..34162ca14093 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep) SZ_1M); if (!ep->irq_cpu_addr) { dev_err(dev, "failed to reserve memory space for MSI\n"); + err = -ENOMEM; goto err_epc_mem_exit; }
Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success. Fixes: 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> --- v2: Update the git hash for the Fixes tag because the tree was rebased I guess. drivers/pci/controller/pcie-rockchip-ep.c | 1 + 1 file changed, 1 insertion(+)