| Message ID | 20241212-mbg-v2-support-v2-2-3249a4339b6e@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for MBG Thermal monitoring device | expand |
On Thu, 12 Dec 2024 21:41:21 +0530, Satya Priya Kakitapalli wrote: > Add reference to the newly added MBG thermal monitor bindings. > > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241212-mbg-v2-support-v2-2-3249a4339b6e@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Dec 12, 2024 at 09:41:21PM +0530, Satya Priya Kakitapalli wrote: > Add reference to the newly added MBG thermal monitor bindings. > > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com> You must explain the dependencies between in changelog or cover letter, because you trick now maintainers into applying something which will lead to broken tree. Just squash the patch, it is not a separate feature. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 11da55644262fada1bcd215943078330332156aa..3a1acb658960329e881d67e264d221764bcec57e 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -209,6 +209,10 @@ patternProperties: $ref: /schemas/leds/backlight/qcom-wled.yaml# unevaluatedProperties: false + "temperature-sensor@[0-9a-f]+$": + type: object + $ref: /schemas/thermal/qcom-spmi-mbg-tm.yaml# + required: - compatible - reg
Add reference to the newly added MBG thermal monitor bindings. Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++ 1 file changed, 4 insertions(+)