| Message ID | 20241212212941.1268662-2-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Three small block layer patches | expand |
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
On 12/12/24 01:29PM, Bart Van Assche wrote: >Since commit fde02699c242 ("block: mq-deadline: Remove support for zone >write locking"), the local variable 'insert_before' is assigned once and >is used once. Hence remove this local variable. > >Reviewed-by: Damien Le Moal <dlemoal@kernel.org> >Cc: Christoph Hellwig <hch@lst.de> >Signed-off-by: Bart Van Assche <bvanassche@acm.org> >--- Reviewed-by: Nitesh Shetty <nj.shetty@samsung.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff --git a/block/mq-deadline.c b/block/mq-deadline.c index 91b3789f710e..5528347b5fcf 100644 --- a/block/mq-deadline.c +++ b/block/mq-deadline.c @@ -698,8 +698,6 @@ static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq, list_add(&rq->queuelist, &per_prio->dispatch); rq->fifo_time = jiffies; } else { - struct list_head *insert_before; - deadline_add_rq_rb(per_prio, rq); if (rq_mergeable(rq)) { @@ -712,8 +710,7 @@ static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq, * set expire time and add to fifo list */ rq->fifo_time = jiffies + dd->fifo_expire[data_dir]; - insert_before = &per_prio->fifo_list[data_dir]; - list_add_tail(&rq->queuelist, insert_before); + list_add_tail(&rq->queuelist, &per_prio->fifo_list[data_dir]); } }
Since commit fde02699c242 ("block: mq-deadline: Remove support for zone write locking"), the local variable 'insert_before' is assigned once and is used once. Hence remove this local variable. Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/mq-deadline.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)