| Message ID | 20241212-speedy-v1-0-544ad7bcfb6a@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Samsung SPEEDY serial bus host controller driver | expand |
On 12/12/2024 22:09, Markuss Broks wrote: > Hey, > > This series adds support for the Samsung SPEEDY serial bus host > controller. Samsung SPEEDY (actually an acronym) is a proprietary > Samsung 1 wire serial bus, which is used on various Samsung devices. > It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Please run standard kernel tools for static analysis, like coccinelle, smatch and sparse, and fix reported warnings. Also please check for warnings when building with W=1. Most of these commands (checks or W=1 build) can build specific targets, like some directory, to narrow the scope to only your code. The code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
Hey, This series adds support for the Samsung SPEEDY serial bus host controller. Samsung SPEEDY (actually an acronym) is a proprietary Samsung 1 wire serial bus, which is used on various Samsung devices. This driver adds support for the version of controller without the IP_BATCHER block. It appears that block is a small MCU attached to the SPEEDY controller to offload the SPEEDY I/O tasks from the AP. IP_BATCHER is found on Exynos7885, but not found on Exynos9810 and Exynos8895. This version of driver should still work on Exynos7885 though, but the IP_BATCHER is not supported at the moment. On Exynos9810, SPEEDY controllers are also mapped into MMIO space of other processors on the CPU. For example, APM also has a window to the SPEEDY IP, and it uses it for power-management related things. During testing however, it seems that if APM is not active the AP can access the SPEEDY controller freely and without interference from APM firmware. Things to improve: - SPEEDY host controller has an interrupt line to the AP, but current implementation uses polling instead, - add support for handling IP_BATCHER block, - add support for bulk transfers, - test on other SoCs (Exynos9820, 9830, 9840, ...). - runtime PM - Markuss To: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk+dt@kernel.org> To: Conor Dooley <conor+dt@kernel.org> To: Alim Akhtar <alim.akhtar@samsung.com> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: linux-samsung-soc@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> Signed-off-by: Markuss Broks <markuss.broks@gmail.com> --- Markuss Broks (3): dt-bindings: soc: samsung: exynos-speedy: Document SPEEDY host controller bindings soc: samsung: Add a driver for Samsung SPEEDY host controller MAINTAINERS: Add entry for the Samsung Exynos SPEEDY host controller .../bindings/soc/samsung/exynos-speedy.yaml | 78 ++++ MAINTAINERS | 7 + drivers/soc/samsung/Kconfig | 13 + drivers/soc/samsung/Makefile | 2 + drivers/soc/samsung/exynos-speedy.c | 457 +++++++++++++++++++++ include/linux/soc/samsung/exynos-speedy.h | 56 +++ 6 files changed, 613 insertions(+) --- base-commit: 1b2ab8149928c1cea2d7eca30cd35bb7fe014053 change-id: 20241210-speedy-e43f5df2b1d6 Best regards,