| Message ID | 20241213151415.7opofgiz25lpmn5m@basti-XPS-13-9310 (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL,FOR,6.13] FIXES: Vcodec fixes | expand |
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/20241213151415.7opofgiz25lpmn5m@basti-XPS-13-9310/
Build log: https://builder.linuxtv.org/job/patchwork/407542/
Build time: 00:09:31
Link: https://lore.kernel.org/linux-media/20241213151415.7opofgiz25lpmn5m@basti-XPS-13-9310
gpg: Signature made Fri 13 Dec 2024 03:11:21 PM UTC
gpg: using RSA key B71AEACB392868D77606602EC26580EBB1C88525
gpg: requesting key C26580EBB1C88525 from hkps://keyserver.ubuntu.com
gpg: Can't check signature: No public key
Summary: no issues. All 2 looked fine.
Hi Sebastian, Arnd, While cleaning up patchwork I stumbled on this PR. The odd thing is that the second patch (noinline) is committed, but not the first (avoid warning). Is it still needed? I'm not sure what happened here. The patch is still marked as 'New' in patchwork: https://patchwork.linuxtv.org/project/linux-media/patch/20241018152127.3958436-1-arnd@kernel.org/ The already committed patch was also still marked as 'New', I've changed the state to 'Accepted'. Regards, Hans On 13/12/2024 16:14, Sebastian Fricke wrote: > Hey Mauro & Hans, > > this is my first time doing a pull request for the fixes branch, so > sorry in advance if I did something incorrectly. These are two small > fixes, which I would like to see landing in 6.13 if that is still > possible. > > --- > > The following changes since commit 2dd59fe0e19e1ab955259978082b62e5751924c7: > > media: dvb-frontends: dib3000mb: fix uninit-value in dib3000_write_reg (2024-12-11 17:54:19 +0100) > > are available in the Git repository at: > > https://gitlab.collabora.com/sebastianfricke/linux.git tags/for-6.13-vcodec-fixes > > for you to fetch changes up to 531a8089b1f45cccd6e9a959bfbd20ecccdb56d4: > > media: mediatek: vcodec: mark vdec_vp9_slice_map_counts_eob_coef noinline (2024-12-13 16:10:18 +0100) > > ---------------------------------------------------------------- > Two small fixes for VCodec > > ---------------------------------------------------------------- > Arnd Bergmann (2): > media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warning > media: mediatek: vcodec: mark vdec_vp9_slice_map_counts_eob_coef noinline > > .../platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 3 ++- > drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c | 6 +++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > > Regards, > Sebastian >
On 20/02/2025 11:15, Hans Verkuil wrote: > Hi Sebastian, Arnd, > > While cleaning up patchwork I stumbled on this PR. > > The odd thing is that the second patch (noinline) is committed, but not the first (avoid warning). > > Is it still needed? I'm not sure what happened here. > > The patch is still marked as 'New' in patchwork: > > https://patchwork.linuxtv.org/project/linux-media/patch/20241018152127.3958436-1-arnd@kernel.org/ Apparently this just got lost somehow. I'll delegate this patch to me and queue it up for v6.15. I don't think this needs to go to v6.14 since I understand it just kills a warning. Regards, Hans > > The already committed patch was also still marked as 'New', I've changed the state to 'Accepted'. > > Regards, > > Hans > > On 13/12/2024 16:14, Sebastian Fricke wrote: >> Hey Mauro & Hans, >> >> this is my first time doing a pull request for the fixes branch, so >> sorry in advance if I did something incorrectly. These are two small >> fixes, which I would like to see landing in 6.13 if that is still >> possible. >> >> --- >> >> The following changes since commit 2dd59fe0e19e1ab955259978082b62e5751924c7: >> >> media: dvb-frontends: dib3000mb: fix uninit-value in dib3000_write_reg (2024-12-11 17:54:19 +0100) >> >> are available in the Git repository at: >> >> https://gitlab.collabora.com/sebastianfricke/linux.git tags/for-6.13-vcodec-fixes >> >> for you to fetch changes up to 531a8089b1f45cccd6e9a959bfbd20ecccdb56d4: >> >> media: mediatek: vcodec: mark vdec_vp9_slice_map_counts_eob_coef noinline (2024-12-13 16:10:18 +0100) >> >> ---------------------------------------------------------------- >> Two small fixes for VCodec >> >> ---------------------------------------------------------------- >> Arnd Bergmann (2): >> media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warning >> media: mediatek: vcodec: mark vdec_vp9_slice_map_counts_eob_coef noinline >> >> .../platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 3 ++- >> drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c | 6 +++++- >> 2 files changed, 7 insertions(+), 2 deletions(-) >> >> Regards, >> Sebastian >> > >
On Thu, Feb 20, 2025, at 12:01, Hans Verkuil wrote: > On 20/02/2025 11:15, Hans Verkuil wrote: >> Hi Sebastian, Arnd, >> >> While cleaning up patchwork I stumbled on this PR. >> >> The odd thing is that the second patch (noinline) is committed, but not the first (avoid warning). >> >> Is it still needed? I'm not sure what happened here. >> >> The patch is still marked as 'New' in patchwork: >> >> https://patchwork.linuxtv.org/project/linux-media/patch/20241018152127.3958436-1-arnd@kernel.org/ > > Apparently this just got lost somehow. I'll delegate this patch to me > and queue it up > for v6.15. I don't think this needs to go to v6.14 since I understand > it just kills > a warning. Thanks! I checked my local tree again, and this is indeed the last patch I have pending that addresses any -Wenum-compare-conditional warning. We have recently moved -Wenum-enum-conversion from W=1 to W=2, ideally we can move -Wenum-compare-conditional from W=1 to default once this patch is in. It's probably also a good time for me to switch my daily testing over from gcc to clang and see if any other -Wenum-compare-conditional warnings have come up. Arnd
Hey Mauro & Hans, this is my first time doing a pull request for the fixes branch, so sorry in advance if I did something incorrectly. These are two small fixes, which I would like to see landing in 6.13 if that is still possible. --- The following changes since commit 2dd59fe0e19e1ab955259978082b62e5751924c7: media: dvb-frontends: dib3000mb: fix uninit-value in dib3000_write_reg (2024-12-11 17:54:19 +0100) are available in the Git repository at: https://gitlab.collabora.com/sebastianfricke/linux.git tags/for-6.13-vcodec-fixes for you to fetch changes up to 531a8089b1f45cccd6e9a959bfbd20ecccdb56d4: media: mediatek: vcodec: mark vdec_vp9_slice_map_counts_eob_coef noinline (2024-12-13 16:10:18 +0100) ---------------------------------------------------------------- Two small fixes for VCodec ---------------------------------------------------------------- Arnd Bergmann (2): media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warning media: mediatek: vcodec: mark vdec_vp9_slice_map_counts_eob_coef noinline .../platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 3 ++- drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) Regards, Sebastian