[net,0/5] netdev: fix repeated netlink messages in queue dumps

Message

Jakub Kicinski Dec. 13, 2024, 3:22 p.m. UTC

Fix dump continuation for queues and queue stats in the netdev family.
Because we used post-increment when saving id of dumped queue next
skb would re-dump the already dumped queue.

Jakub Kicinski (5):
  netdev: fix repeated netlink messages in queue dump
  netdev: fix repeated netlink messages in queue stats
  selftests: net: support setting recv_size in YNL
  selftests: net-drv: queues: sanity check netlink dumps
  selftests: net-drv: stats: sanity check netlink dumps

 net/core/netdev-genl.c                        | 15 +++++-------
 tools/testing/selftests/drivers/net/queues.py | 23 +++++++++++--------
 tools/testing/selftests/drivers/net/stats.py  | 19 ++++++++++++++-
 tools/testing/selftests/net/lib/py/ynl.py     | 16 ++++++-------
 4 files changed, 45 insertions(+), 28 deletions(-)

Comments

Joe Damato Dec. 13, 2024, 9:52 p.m. UTC | #1

On Fri, Dec 13, 2024 at 07:22:39AM -0800, Jakub Kicinski wrote:
> Fix dump continuation for queues and queue stats in the netdev family.
> Because we used post-increment when saving id of dumped queue next
> skb would re-dump the already dumped queue.
> 
> Jakub Kicinski (5):
>   netdev: fix repeated netlink messages in queue dump
>   netdev: fix repeated netlink messages in queue stats
>   selftests: net: support setting recv_size in YNL
>   selftests: net-drv: queues: sanity check netlink dumps
>   selftests: net-drv: stats: sanity check netlink dumps

Thanks for the work and improvements.

Patch 1 and 2 definitely seem to be "fixes" and are against net
which seems appropriate to me.

Patches 3, 4, and 5 seem like new features, though. Should those
three be a separate series against net-next, instead?

In the event that you do decide to separate out 3, 4, and 5 you can
feel free to carry along my Reviewed-bys.

Jakub Kicinski Dec. 14, 2024, 1:38 a.m. UTC | #2

Thanks for the reviews!

On Fri, 13 Dec 2024 13:52:11 -0800 Joe Damato wrote:
> Patches 3, 4, and 5 seem like new features, though. Should those
> three be a separate series against net-next, instead?

Right, this case is a bit disputable. Docs and selftests can't really
break the current release. And someone who backports the fixes should 
be able to easily test them.

Also, thinking selfishly as a maintainer, having them in one series
saves me mental tracking of who promised to send tests via another
tree and hasn't posted them yet.

[e-mail] Dec. 17, 2024, 1:50 a.m. UTC | #3

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Fri, 13 Dec 2024 07:22:39 -0800 you wrote:
> Fix dump continuation for queues and queue stats in the netdev family.
> Because we used post-increment when saving id of dumped queue next
> skb would re-dump the already dumped queue.
> 
> Jakub Kicinski (5):
>   netdev: fix repeated netlink messages in queue dump
>   netdev: fix repeated netlink messages in queue stats
>   selftests: net: support setting recv_size in YNL
>   selftests: net-drv: queues: sanity check netlink dumps
>   selftests: net-drv: stats: sanity check netlink dumps
> 
> [...]

Here is the summary with links:
  - [net,1/5] netdev: fix repeated netlink messages in queue dump
    https://git.kernel.org/netdev/net/c/b1f3a2f5a742
  - [net,2/5] netdev: fix repeated netlink messages in queue stats
    https://git.kernel.org/netdev/net/c/ecc391a54157
  - [net,3/5] selftests: net: support setting recv_size in YNL
    https://git.kernel.org/netdev/net/c/0518863407b8
  - [net,4/5] selftests: net-drv: queues: sanity check netlink dumps
    https://git.kernel.org/netdev/net/c/1234810b1649
  - [net,5/5] selftests: net-drv: stats: sanity check netlink dumps
    https://git.kernel.org/netdev/net/c/5712e323d4c3

You are awesome, thank you!