| Message ID | 20241213164445.23195-3-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v8,1/8] iio: backend: add API for interface get | expand |
On 12/13/24 10:44 AM, Antoniu Miclaus wrote: > Add backend support for setting oversampling ratio. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > changes in v8: > - pass oversampling ratio > drivers/iio/industrialio-backend.c | 15 +++++++++++++++ > include/linux/iio/backend.h | 5 +++++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-backend.c > index ea184fc2c838..e56b1e96652d 100644 > --- a/drivers/iio/industrialio-backend.c > +++ b/drivers/iio/industrialio-backend.c > @@ -681,6 +681,21 @@ int iio_backend_data_size_set(struct iio_backend *back, unsigned int size) > } > EXPORT_SYMBOL_NS_GPL(iio_backend_data_size_set, IIO_BACKEND); > > +/** > + * iio_backend_oversampling_ratio_set - set the oversampling ratio > + * @back: Backend device > + * @ratio: The oversampling ratio > + * > + * Return: > + * 0 on success, negative error number on failure. > + */ > +int iio_backend_oversampling_ratio_set(struct iio_backend *back, > + unsigned int ratio) > +{ > + return iio_backend_op_call(back, oversampling_ratio_set, ratio); > +} > +EXPORT_SYMBOL_NS_GPL(iio_backend_oversampling_ratio_set, IIO_BACKEND); > + Needs quotes on "IIO_BACKEND" here. With that... Reviewed-by: David Lechner <dlechner@baylibre.com>
On Fri, 13 Dec 2024 17:10:58 -0600 David Lechner <dlechner@baylibre.com> wrote: > On 12/13/24 10:44 AM, Antoniu Miclaus wrote: > > Add backend support for setting oversampling ratio. > > > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > > --- > > changes in v8: > > - pass oversampling ratio > > drivers/iio/industrialio-backend.c | 15 +++++++++++++++ > > include/linux/iio/backend.h | 5 +++++ > > 2 files changed, 20 insertions(+) > > > > diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-backend.c > > index ea184fc2c838..e56b1e96652d 100644 > > --- a/drivers/iio/industrialio-backend.c > > +++ b/drivers/iio/industrialio-backend.c > > @@ -681,6 +681,21 @@ int iio_backend_data_size_set(struct iio_backend *back, unsigned int size) > > } > > EXPORT_SYMBOL_NS_GPL(iio_backend_data_size_set, IIO_BACKEND); > > > > +/** > > + * iio_backend_oversampling_ratio_set - set the oversampling ratio > > + * @back: Backend device > > + * @ratio: The oversampling ratio The 0 vs 1 as no oversampling debate has happened a few times. Perhaps just add to documentation here to say 1 is used to mean no oversampling. Thanks, Jonathan > > + * > > + * Return: > > + * 0 on success, negative error number on failure. > > + */ > > +int iio_backend_oversampling_ratio_set(struct iio_backend *back, > > + unsigned int ratio) > > +{ > > + return iio_backend_op_call(back, oversampling_ratio_set, ratio); > > +} > > +EXPORT_SYMBOL_NS_GPL(iio_backend_oversampling_ratio_set, IIO_BACKEND); > > + > Needs quotes on "IIO_BACKEND" here. > > With that... > > Reviewed-by: David Lechner <dlechner@baylibre.com> >
diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-backend.c index ea184fc2c838..e56b1e96652d 100644 --- a/drivers/iio/industrialio-backend.c +++ b/drivers/iio/industrialio-backend.c @@ -681,6 +681,21 @@ int iio_backend_data_size_set(struct iio_backend *back, unsigned int size) } EXPORT_SYMBOL_NS_GPL(iio_backend_data_size_set, IIO_BACKEND); +/** + * iio_backend_oversampling_ratio_set - set the oversampling ratio + * @back: Backend device + * @ratio: The oversampling ratio + * + * Return: + * 0 on success, negative error number on failure. + */ +int iio_backend_oversampling_ratio_set(struct iio_backend *back, + unsigned int ratio) +{ + return iio_backend_op_call(back, oversampling_ratio_set, ratio); +} +EXPORT_SYMBOL_NS_GPL(iio_backend_oversampling_ratio_set, IIO_BACKEND); + /** * iio_backend_extend_chan_spec - Extend an IIO channel * @back: Backend device diff --git a/include/linux/iio/backend.h b/include/linux/iio/backend.h index 59b6651b7eaf..1bde32689776 100644 --- a/include/linux/iio/backend.h +++ b/include/linux/iio/backend.h @@ -94,6 +94,7 @@ enum iio_backend_interface_type { * @ext_info_get: Extended info getter. * @interface_type_get: Interface type. * @data_size_set: Data size. + * @oversampling_ratio_set: Set Oversampling ratio. * @read_raw: Read a channel attribute from a backend device * @debugfs_print_chan_status: Print channel status into a buffer. * @debugfs_reg_access: Read or write register value of backend. @@ -132,6 +133,8 @@ struct iio_backend_ops { int (*interface_type_get)(struct iio_backend *back, enum iio_backend_interface_type *type); int (*data_size_set)(struct iio_backend *back, unsigned int size); + int (*oversampling_ratio_set)(struct iio_backend *back, + unsigned int ratio); int (*read_raw)(struct iio_backend *back, struct iio_chan_spec const *chan, int *val, int *val2, long mask); @@ -183,6 +186,8 @@ ssize_t iio_backend_ext_info_get(struct iio_dev *indio_dev, uintptr_t private, int iio_backend_interface_type_get(struct iio_backend *back, enum iio_backend_interface_type *type); int iio_backend_data_size_set(struct iio_backend *back, unsigned int size); +int iio_backend_oversampling_ratio_set(struct iio_backend *back, + unsigned int ratio); int iio_backend_read_raw(struct iio_backend *back, struct iio_chan_spec const *chan, int *val, int *val2, long mask);
Add backend support for setting oversampling ratio. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- changes in v8: - pass oversampling ratio drivers/iio/industrialio-backend.c | 15 +++++++++++++++ include/linux/iio/backend.h | 5 +++++ 2 files changed, 20 insertions(+)