| Message ID | 20241213095201.1218145-3-darius.berghe@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: accel: adxl367: add support for adxl366 | expand |
On Fri, 13 Dec 2024 11:52:01 +0200 Darius Berghe <darius.berghe@analog.com> wrote: > Add support for adxl366 Micropower, 3-Axis, +-/2g, +/-4g, +/-8g > Digital Output MEMS Accelerometer into the existing adxl367 iio > subsystem driver. > > adxl366 supports all the features of adxl367 but has a few > additional features for which support is added in this patch: > - built-in step counting (pedometer) > - non-linearity compensation for Z axis That description makes it sound like you could use a fallback compatible. Would it 'work' with those features missing using the adxl367 compatible? > > Signed-off-by: Darius Berghe <darius.berghe@analog.com> > --- > Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml > index f10d98d34cb8..272be616e979 100644 > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml > @@ -27,6 +27,7 @@ description: | > properties: > compatible: > enum: > + - adi,adxl366 > - adi,adxl367 > > reg:
On Fri, Dec 13, 2024 at 11:52:01AM +0200, Darius Berghe wrote: > Add support for adxl366 Micropower, 3-Axis, +-/2g, +/-4g, +/-8g > Digital Output MEMS Accelerometer into the existing adxl367 iio > subsystem driver. Bindings are before users. > > adxl366 supports all the features of adxl367 but has a few > additional features for which support is added in this patch: Where do you add these features in the binding? I cannot find them, so maybe you reference something else. > - built-in step counting (pedometer) > - non-linearity compensation for Z axis Are the devices compatible? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml index f10d98d34cb8..272be616e979 100644 --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml @@ -27,6 +27,7 @@ description: | properties: compatible: enum: + - adi,adxl366 - adi,adxl367 reg:
Add support for adxl366 Micropower, 3-Axis, +-/2g, +/-4g, +/-8g Digital Output MEMS Accelerometer into the existing adxl367 iio subsystem driver. adxl366 supports all the features of adxl367 but has a few additional features for which support is added in this patch: - built-in step counting (pedometer) - non-linearity compensation for Z axis Signed-off-by: Darius Berghe <darius.berghe@analog.com> --- Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml | 1 + 1 file changed, 1 insertion(+)