| Message ID | 20241211-dlech-mainline-spi-engine-offload-2-v6-3-88ee574d5d03@baylibre.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | spi: axi-spi-engine: add offload support | expand |
On Wed, 11 Dec 2024 14:54:40 -0600 David Lechner <dlechner@baylibre.com> wrote: > Add a new binding for using a PWM signal as a trigger source. > > The idea here is similar to e.g. "pwm-clock" to allow a trigger source > consumer to use a PWM provider as a trigger source. > > Signed-off-by: David Lechner <dlechner@baylibre.com> LGTM. But obviously this is really one for the dt-binding maintainers to look at. With that in mind. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > > v6 changes: > * Moved file from bindings/spi/ to bindings/trigger-source/ > * Updated description to not mention SPI > * Dropped $ref: /schemas/spi/trigger-source.yaml# > * Swapped order in name to be consistent with "pwm-clock" > > v5 changes: > * Add MAINTAINERS entry > > v4 changes: new patch in v4 > --- > .../bindings/trigger-source/pwm-trigger.yaml | 37 ++++++++++++++++++++++ > MAINTAINERS | 5 +++ > 2 files changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml b/Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..1eac20031dc3cf921aafb8aa37f4e4eca1075835 > --- /dev/null > +++ b/Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/trigger-source/pwm-trigger.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic trigger source using PWM > + > +description: Remaps a PWM channel as a trigger source. > + > +maintainers: > + - David Lechner <dlechner@baylibre.com> > + > +properties: > + compatible: > + const: pwm-trigger > + > + '#trigger-source-cells': > + const: 0 > + > + pwms: > + maxItems: 1 > + > +required: > + - compatible > + - '#trigger-source-cells' > + - pwms > + > +additionalProperties: false > + > +examples: > + - | > + trigger { > + compatible = "pwm-trigger"; > + #trigger-source-cells = <0>; > + pwms = <&pwm 0 1000000 0>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 9284a257607a740ab7f6fd960c2bcdc34ead7586..b2aa6f37743e48353c60e5973ea8126590c7f6d5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23879,6 +23879,11 @@ W: https://github.com/srcres258/linux-doc > T: git git://github.com/srcres258/linux-doc.git doc-zh-tw > F: Documentation/translations/zh_TW/ > > +TRIGGER SOURCE - PWM > +M: David Lechner <dlechner@baylibre.com> > +S: Maintained > +F: Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml > + > TRUSTED SECURITY MODULE (TSM) ATTESTATION REPORTS > M: Dan Williams <dan.j.williams@intel.com> > L: linux-coco@lists.linux.dev >
On Wed, 11 Dec 2024 14:54:40 -0600, David Lechner wrote: > Add a new binding for using a PWM signal as a trigger source. > > The idea here is similar to e.g. "pwm-clock" to allow a trigger source > consumer to use a PWM provider as a trigger source. > > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- > > v6 changes: > * Moved file from bindings/spi/ to bindings/trigger-source/ > * Updated description to not mention SPI > * Dropped $ref: /schemas/spi/trigger-source.yaml# > * Swapped order in name to be consistent with "pwm-clock" > > v5 changes: > * Add MAINTAINERS entry > > v4 changes: new patch in v4 > --- > .../bindings/trigger-source/pwm-trigger.yaml | 37 ++++++++++++++++++++++ > MAINTAINERS | 5 +++ > 2 files changed, 42 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml b/Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml new file mode 100644 index 0000000000000000000000000000000000000000..1eac20031dc3cf921aafb8aa37f4e4eca1075835 --- /dev/null +++ b/Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/trigger-source/pwm-trigger.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic trigger source using PWM + +description: Remaps a PWM channel as a trigger source. + +maintainers: + - David Lechner <dlechner@baylibre.com> + +properties: + compatible: + const: pwm-trigger + + '#trigger-source-cells': + const: 0 + + pwms: + maxItems: 1 + +required: + - compatible + - '#trigger-source-cells' + - pwms + +additionalProperties: false + +examples: + - | + trigger { + compatible = "pwm-trigger"; + #trigger-source-cells = <0>; + pwms = <&pwm 0 1000000 0>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 9284a257607a740ab7f6fd960c2bcdc34ead7586..b2aa6f37743e48353c60e5973ea8126590c7f6d5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23879,6 +23879,11 @@ W: https://github.com/srcres258/linux-doc T: git git://github.com/srcres258/linux-doc.git doc-zh-tw F: Documentation/translations/zh_TW/ +TRIGGER SOURCE - PWM +M: David Lechner <dlechner@baylibre.com> +S: Maintained +F: Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml + TRUSTED SECURITY MODULE (TSM) ATTESTATION REPORTS M: Dan Williams <dan.j.williams@intel.com> L: linux-coco@lists.linux.dev
Add a new binding for using a PWM signal as a trigger source. The idea here is similar to e.g. "pwm-clock" to allow a trigger source consumer to use a PWM provider as a trigger source. Signed-off-by: David Lechner <dlechner@baylibre.com> --- v6 changes: * Moved file from bindings/spi/ to bindings/trigger-source/ * Updated description to not mention SPI * Dropped $ref: /schemas/spi/trigger-source.yaml# * Swapped order in name to be consistent with "pwm-clock" v5 changes: * Add MAINTAINERS entry v4 changes: new patch in v4 --- .../bindings/trigger-source/pwm-trigger.yaml | 37 ++++++++++++++++++++++ MAINTAINERS | 5 +++ 2 files changed, 42 insertions(+)