| Message ID | 20241211085636.1380516-38-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/43] xfs: constify feature checks | expand |
On Wed, Dec 11, 2024 at 09:55:02AM +0100, Christoph Hellwig wrote: > They'll need a little more work. I guess we'll have to get back to this... :/ --D > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > fs/xfs/xfs_qm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c > index e1ba5af6250f..417439b58785 100644 > --- a/fs/xfs/xfs_qm.c > +++ b/fs/xfs/xfs_qm.c > @@ -1711,7 +1711,8 @@ xfs_qm_mount_quotas( > * immediately. We only support rtquota if rtgroups are enabled to > * avoid problems with older kernels. > */ > - if (mp->m_sb.sb_rextents && !xfs_has_rtgroups(mp)) { > + if (mp->m_sb.sb_rextents && > + (!xfs_has_rtgroups(mp) || xfs_has_zoned(mp))) { > xfs_notice(mp, "Cannot turn on quotas for realtime filesystem"); > mp->m_qflags = 0; > goto write_changes; > -- > 2.45.2 > >
On Fri, Dec 13, 2024 at 03:05:03PM -0800, Darrick J. Wong wrote: > On Wed, Dec 11, 2024 at 09:55:02AM +0100, Christoph Hellwig wrote: > > They'll need a little more work. > > I guess we'll have to get back to this... :/ Yes. I've always been wanting to implement it, but not with the very highest priority. The fact that you pulled up the RT quota series to earlier in your patch stack threw a little monkey wrench here :)
diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c index e1ba5af6250f..417439b58785 100644 --- a/fs/xfs/xfs_qm.c +++ b/fs/xfs/xfs_qm.c @@ -1711,7 +1711,8 @@ xfs_qm_mount_quotas( * immediately. We only support rtquota if rtgroups are enabled to * avoid problems with older kernels. */ - if (mp->m_sb.sb_rextents && !xfs_has_rtgroups(mp)) { + if (mp->m_sb.sb_rextents && + (!xfs_has_rtgroups(mp) || xfs_has_zoned(mp))) { xfs_notice(mp, "Cannot turn on quotas for realtime filesystem"); mp->m_qflags = 0; goto write_changes;
They'll need a little more work. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/xfs_qm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)