| Message ID | 20241216043910.11875-1-fido_max@inbox.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] ASoC: codecs: nau8824: fix max volume for Speaker output | expand |
On Mon, Dec 16, 2024 at 6:39 AM Maxim Kochetkov <fido_max@inbox.ru> wrote: > > There is no audio output if Speaker volume is set above 25. > According to datasheet maximum allowed value for the Speaker > output is 0b11001 (25). > So adjust this value with datasheet. ...in accordance with the datasheet. Can you add the section number and its title and possibly the version of the datasheet?
16.12.2024 10:41, Andy Shevchenko wrote: > On Mon, Dec 16, 2024 at 6:39 AM Maxim Kochetkov <fido_max@inbox.ru> wrote: >> >> There is no audio output if Speaker volume is set above 25. >> According to datasheet maximum allowed value for the Speaker >> output is 0b11001 (25). >> So adjust this value with datasheet. > > ...in accordance with the datasheet. > > Can you add the section number and its title and possibly the version > of the datasheet? Rev 2.5 0x6D CLASSD_GAIN_1/ 0x6E CLASSD_GAIN_2: Left/Right Channel Class-D Driver Gain For DAC Left/Right Input (Step size is 1dB.) 00000 = Mute (DEFAULT) 00001 = 0dB 00002 = 1dB ... 11000 = 23dB 11001 = 24dB I will add it in V2
diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 12540397fd4d..5aaf8c496300 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -368,13 +368,13 @@ static const struct snd_kcontrol_new nau8824_snd_controls[] = { SOC_ENUM("DAC Oversampling Rate", nau8824_dac_oversampl_enum), SOC_SINGLE_TLV("Speaker Right DACR Volume", - NAU8824_REG_CLASSD_GAIN_1, 8, 0x1f, 0, spk_vol_tlv), + NAU8824_REG_CLASSD_GAIN_1, 8, 0x19, 0, spk_vol_tlv), SOC_SINGLE_TLV("Speaker Left DACL Volume", - NAU8824_REG_CLASSD_GAIN_2, 0, 0x1f, 0, spk_vol_tlv), + NAU8824_REG_CLASSD_GAIN_2, 0, 0x19, 0, spk_vol_tlv), SOC_SINGLE_TLV("Speaker Left DACR Volume", - NAU8824_REG_CLASSD_GAIN_1, 0, 0x1f, 0, spk_vol_tlv), + NAU8824_REG_CLASSD_GAIN_1, 0, 0x19, 0, spk_vol_tlv), SOC_SINGLE_TLV("Speaker Right DACL Volume", - NAU8824_REG_CLASSD_GAIN_2, 8, 0x1f, 0, spk_vol_tlv), + NAU8824_REG_CLASSD_GAIN_2, 8, 0x19, 0, spk_vol_tlv), SOC_SINGLE_TLV("Headphone Right DACR Volume", NAU8824_REG_ATT_PORT0, 8, 0x1f, 0, hp_vol_tlv),
There is no audio output if Speaker volume is set above 25. According to datasheet maximum allowed value for the Speaker output is 0b11001 (25). So adjust this value with datasheet. Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru> --- sound/soc/codecs/nau8824.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)