| Message ID | 20241213103939.3851827-2-mkumard@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Tegra ADMA channel page support | expand |
On Fri, Dec 13, 2024 at 04:09:38PM +0530, Mohan Kumar D wrote: > Multiple ADMA Channel page hardware support has been added from > TEGRA186 and onwards. Update the DT binding to use any of the > ADMA channel page address space region. > > Signed-off-by: Mohan Kumar D <mkumard@nvidia.com> > --- This is v2 but no changelog, no explanation whatsoever... I assume feedback was not implemented, so please go back to previous version and address the feedback and then send proper new version with changelog. See submitting patches. Best regards, Krzysztof
On 16-12-2024 15:00, Krzysztof Kozlowski wrote: > External email: Use caution opening links or attachments > > > On Fri, Dec 13, 2024 at 04:09:38PM +0530, Mohan Kumar D wrote: >> Multiple ADMA Channel page hardware support has been added from >> TEGRA186 and onwards. Update the DT binding to use any of the >> ADMA channel page address space region. >> >> Signed-off-by: Mohan Kumar D <mkumard@nvidia.com> >> --- > This is v2 but no changelog, no explanation whatsoever... I assume > feedback was not implemented, so please go back to previous version and > address the feedback and then send proper new version with changelog. > > See submitting patches. It's my bad to not include the changelog info, though I have taken care of the feedback on the ADMA DT bindings. I will include the changelog info and resend the v2. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml index 877147e95ecc..d3f8c269916c 100644 --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml @@ -13,9 +13,6 @@ description: | maintainers: - Jon Hunter <jonathanh@nvidia.com> -allOf: - - $ref: dma-controller.yaml# - properties: compatible: oneOf: @@ -29,7 +26,19 @@ properties: - const: nvidia,tegra186-adma reg: - maxItems: 1 + description: + The 'page' region describes the address space of the page + used for accessing the DMA channel registers. The 'global' + region describes the address space of the global DMA registers. + In the absence of the 'reg-names' property, there must be a + single entry that covers the address space of the global DMA + registers and the DMA channel registers. + minItems: 1 + maxItems: 2 + + reg-names: + minItems: 1 + maxItems: 2 interrupts: description: | @@ -63,6 +72,49 @@ required: - clocks - clock-names +allOf: + - $ref: dma-controller.yaml# + - if: + properties: + compatible: + contains: + enum: + - nvidia,tegra210-adma + then: + properties: + reg: + items: + - description: Full address space range of DMA registers. + + - if: + properties: + compatible: + contains: + enum: + - nvidia,tegra186-adma + then: + anyOf: + - properties: + reg: + items: + - description: Full address space range of DMA registers. + - properties: + reg: + items: + - description: Channel Page address space range of DMA registers. + reg-names: + items: + - const: page + - properties: + reg: + items: + - description: Channel Page address space range of DMA registers. + - description: Global Page address space range of DMA registers. + reg-names: + items: + - const: page + - const: global + additionalProperties: false examples:
Multiple ADMA Channel page hardware support has been added from TEGRA186 and onwards. Update the DT binding to use any of the ADMA channel page address space region. Signed-off-by: Mohan Kumar D <mkumard@nvidia.com> --- .../bindings/dma/nvidia,tegra210-adma.yaml | 60 +++++++++++++++++-- 1 file changed, 56 insertions(+), 4 deletions(-)