| Message ID | 20241212-class_fix-v3-6-04e20c4f0971@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | driver core: class: Fix bug and code improvements for class APIs | expand |
On Thu, 12 Dec 2024 21:38:42 +0800 Zijun Hu <zijun_hu@icloud.com> wrote: > From: Zijun Hu <quic_zijuhu@quicinc.com> > > For APIs: > device_find_child() > device_for_each_child() > device_for_each_child_reverse() > > Their declaration has parameter name 'dev', but their defination > changes the name to 'parent'. > > Rename declaration name to defination 'parent' to make both have > the same name. > > Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
On Thu, Dec 12, 2024 at 09:38:42PM +0800, Zijun Hu wrote: > From: Zijun Hu <quic_zijuhu@quicinc.com> > > For APIs: > device_find_child() > device_for_each_child() > device_for_each_child_reverse() > > Their declaration has parameter name 'dev', but their defination > changes the name to 'parent'. > > Rename declaration name to defination 'parent' to make both have > the same name. > > Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> Reviewed-by: Fan Ni <fan.ni@samsung.com> > --- > include/linux/device.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/device.h b/include/linux/device.h > index 0e0bc9bfe0d15a8734bf3d34106300f4df6b5364..a9d928398895b062094b94f2c188cbe9951d7ac1 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -1074,14 +1074,14 @@ void device_del(struct device *dev); > > DEFINE_FREE(device_del, struct device *, if (_T) device_del(_T)) > > -int device_for_each_child(struct device *dev, void *data, > +int device_for_each_child(struct device *parent, void *data, > int (*fn)(struct device *dev, void *data)); > -int device_for_each_child_reverse(struct device *dev, void *data, > +int device_for_each_child_reverse(struct device *parent, void *data, > int (*fn)(struct device *dev, void *data)); > int device_for_each_child_reverse_from(struct device *parent, > struct device *from, const void *data, > int (*fn)(struct device *, const void *)); > -struct device *device_find_child(struct device *dev, const void *data, > +struct device *device_find_child(struct device *parent, const void *data, > device_match_t match); > struct device *device_find_child_by_name(struct device *parent, > const char *name); > > -- > 2.34.1 >
diff --git a/include/linux/device.h b/include/linux/device.h index 0e0bc9bfe0d15a8734bf3d34106300f4df6b5364..a9d928398895b062094b94f2c188cbe9951d7ac1 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -1074,14 +1074,14 @@ void device_del(struct device *dev); DEFINE_FREE(device_del, struct device *, if (_T) device_del(_T)) -int device_for_each_child(struct device *dev, void *data, +int device_for_each_child(struct device *parent, void *data, int (*fn)(struct device *dev, void *data)); -int device_for_each_child_reverse(struct device *dev, void *data, +int device_for_each_child_reverse(struct device *parent, void *data, int (*fn)(struct device *dev, void *data)); int device_for_each_child_reverse_from(struct device *parent, struct device *from, const void *data, int (*fn)(struct device *, const void *)); -struct device *device_find_child(struct device *dev, const void *data, +struct device *device_find_child(struct device *parent, const void *data, device_match_t match); struct device *device_find_child_by_name(struct device *parent, const char *name);