| Message ID | 20241216-dpu-fix-catalog-v1-7-15bf0807dba1@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm/dpu: catalog corrections | expand |
On 12/16/2024 12:27 AM, Dmitry Baryshkov wrote: > Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. > > Fixes: e3b1f369db5a ("drm/msm/dpu: Add X1E80100 support") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On Mon, Dec 16, 2024 at 10:27:28AM +0200, Dmitry Baryshkov wrote: > Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. Please say something about why you're doing this and what the expected outcome of doing so is. There is currently no way for a third party (e.g. stable or distro maintainer) to determine what this patch does, if it needs to be backported or if it's essentially just a clean up like Abhinav indicated in one of his replies. > Fixes: e3b1f369db5a ("drm/msm/dpu: Add X1E80100 support") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Johan
On Tue, Dec 17, 2024 at 09:41:44AM +0100, Johan Hovold wrote: > On Mon, Dec 16, 2024 at 10:27:28AM +0200, Dmitry Baryshkov wrote: > > Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. > > Please say something about why you're doing this and what the expected > outcome of doing so is. > > There is currently no way for a third party (e.g. stable or distro > maintainer) to determine what this patch does, if it needs to be > backported or if it's essentially just a clean up like Abhinav indicated > in one of his replies. These patches allow using colour transformation matrix (aka night mode) with more outputs at the same time. I think at this point only CrOS compositor actually uses CTM, so these changes do not need to be backported. However they are not cleanups, it was a feedback for the SM6150 patch for the reasons expressed in the Abhinav's email. > > > Fixes: e3b1f369db5a ("drm/msm/dpu: Add X1E80100 support") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Johan
On Tue, Dec 17, 2024 at 12:38:17PM +0200, Dmitry Baryshkov wrote: > On Tue, Dec 17, 2024 at 09:41:44AM +0100, Johan Hovold wrote: > > On Mon, Dec 16, 2024 at 10:27:28AM +0200, Dmitry Baryshkov wrote: > > > Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. > > > > Please say something about why you're doing this and what the expected > > outcome of doing so is. > > > > There is currently no way for a third party (e.g. stable or distro > > maintainer) to determine what this patch does, if it needs to be > > backported or if it's essentially just a clean up like Abhinav indicated > > in one of his replies. > > These patches allow using colour transformation matrix (aka night mode) > with more outputs at the same time. I think at this point only CrOS > compositor actually uses CTM, so these changes do not need to be > backported. Ok, thanks for clarifying. Can you put something like this in the commit messages so that we have a record of it? > However they are not cleanups, it was a feedback for the > SM6150 patch for the reasons expressed in the Abhinav's email. I don't see any SM6150 patch in the thread. Do you have a pointer? Johan
diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h index d61895bb396fb4287e9b41807a3bb0cdb25d4e25..4f110be6b750d30e158d517aaa507c7b4eda0af4 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h @@ -159,6 +159,7 @@ static const struct dpu_lm_cfg x1e80100_lm[] = { .sblk = &sdm845_lm_sblk, .lm_pair = LM_3, .pingpong = PINGPONG_2, + .dspp = DSPP_2, }, { .name = "lm_3", .id = LM_3, .base = 0x47000, .len = 0x320, @@ -166,6 +167,7 @@ static const struct dpu_lm_cfg x1e80100_lm[] = { .sblk = &sdm845_lm_sblk, .lm_pair = LM_2, .pingpong = PINGPONG_3, + .dspp = DSPP_3, }, { .name = "lm_4", .id = LM_4, .base = 0x48000, .len = 0x320,
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. Fixes: e3b1f369db5a ("drm/msm/dpu: Add X1E80100 support") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 2 ++ 1 file changed, 2 insertions(+)