diff mbox series

dt-bindings: media: imx283: Describe sensor address using the reg property

Message ID 20241217032821.1712916-1-david@ixit.cz (mailing list archive)
State New
Headers show
Series dt-bindings: media: imx283: Describe sensor address using the reg property | expand

Commit Message

David Heidelberg Dec. 17, 2024, 3:28 a.m. UTC
Use the reg property instead of text in the description.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../devicetree/bindings/media/i2c/sony,imx283.yaml         | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Kieran Bingham Dec. 17, 2024, 6:53 a.m. UTC | #1
Quoting David Heidelberg (2024-12-17 03:28:17)
> Use the reg property instead of text in the description.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  .../devicetree/bindings/media/i2c/sony,imx283.yaml         | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> index e4f49f1435a5..f4ee991c89a3 100644
> --- ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> +++ ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> @@ -13,16 +13,15 @@ maintainers:
>  
>  description:
>    IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active
> -  array size of 5472H x 3648V. It is programmable through I2C interface. The
> -  I2C client address is fixed to 0x1a as per sensor data sheet. Image data is
> -  sent through MIPI CSI-2.
> +  array size of 5472H x 3648V. It is programmable through I2C interface.
> +  Image data is sent through MIPI CSI-2.
>  
>  properties:
>    compatible:
>      const: sony,imx283
>  
>    reg:
> -    maxItems: 1
> +    const: 0x1a
>  
>    clocks:
>      description: Clock frequency from 6 to 24 MHz.
> -- 
> 2.45.2
>
Krzysztof Kozlowski Dec. 17, 2024, 7:41 a.m. UTC | #2
On Mon, Dec 16, 2024 at 10:28:17PM -0500, David Heidelberg wrote:
> Use the reg property instead of text in the description.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../devicetree/bindings/media/i2c/sony,imx283.yaml         | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml

Same problems.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Conor Dooley Dec. 17, 2024, 6:25 p.m. UTC | #3
On Mon, Dec 16, 2024 at 10:28:17PM -0500, David Heidelberg wrote:
> Use the reg property instead of text in the description.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Conor Dooley Dec. 17, 2024, 6:27 p.m. UTC | #4
On Tue, Dec 17, 2024 at 06:25:47PM +0000, Conor Dooley wrote:
> On Mon, Dec 16, 2024 at 10:28:17PM -0500, David Heidelberg wrote:
> > Use the reg property instead of text in the description.
> > 
> > Signed-off-by: David Heidelberg <david@ixit.cz>
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Heh, I was super confused as to why I couldn't find this in patchwork
but then realised Krzk had already acked it, d'oh.
diff mbox series

Patch

diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
index e4f49f1435a5..f4ee991c89a3 100644
--- ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
+++ ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
@@ -13,16 +13,15 @@  maintainers:
 
 description:
   IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active
-  array size of 5472H x 3648V. It is programmable through I2C interface. The
-  I2C client address is fixed to 0x1a as per sensor data sheet. Image data is
-  sent through MIPI CSI-2.
+  array size of 5472H x 3648V. It is programmable through I2C interface.
+  Image data is sent through MIPI CSI-2.
 
 properties:
   compatible:
     const: sony,imx283
 
   reg:
-    maxItems: 1
+    const: 0x1a
 
   clocks:
     description: Clock frequency from 6 to 24 MHz.