| Message ID | 20241217-add-venus-for-qcs615-v5-1-747395d9e630@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: venus: enable venus on qcs615 | expand |
On 17/12/2024 10:17, Renjiang Han wrote: > Add qcom,qcs615-venus compatible into qcom,sc7180-venus.yaml for the > video, and let qcom,qcs615-venus fallback to qcom,sc7180-venus on > QCS615 platform. > > Signed-off-by: Renjiang Han <quic_renjiang@quicinc.com> > --- Read that message fully. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 17/12/2024 13:40, Krzysztof Kozlowski wrote: > On 17/12/2024 10:17, Renjiang Han wrote: >> Add qcom,qcs615-venus compatible into qcom,sc7180-venus.yaml for the >> video, and let qcom,qcs615-venus fallback to qcom,sc7180-venus on >> QCS615 platform. >> >> Signed-off-by: Renjiang Han <quic_renjiang@quicinc.com> >> --- > Read that message fully. I meant, message in our previous discussion. > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> Best regards, Krzysztof
On 12/17/2024 8:40 PM, Krzysztof Kozlowski wrote: > On 17/12/2024 13:40, Krzysztof Kozlowski wrote: >> On 17/12/2024 10:17, Renjiang Han wrote: >>> Add qcom,qcs615-venus compatible into qcom,sc7180-venus.yaml for the >>> video, and let qcom,qcs615-venus fallback to qcom,sc7180-venus on >>> QCS615 platform. >>> >>> Signed-off-by: Renjiang Han <quic_renjiang@quicinc.com> >>> --- >> Read that message fully. > I meant, message in our previous discussion. > >> <form letter> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. >> </form letter> > Best regards, > Krzysztof OK, thanks for your reminder. I forgot to add the Reviewed-by tag, that's my mistake. I'll add it in the next patch version.
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml index 5cec1d077cda77817f6d876109defcb0abbfeb2c..de628709fe43b1f3261820b89c65e6eb4dd352e2 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml @@ -18,7 +18,12 @@ allOf: properties: compatible: - const: qcom,sc7180-venus + oneOf: + - items: + - enum: + - qcom,qcs615-venus + - const: qcom,sc7180-venus + - const: qcom,sc7180-venus power-domains: minItems: 2
Add qcom,qcs615-venus compatible into qcom,sc7180-venus.yaml for the video, and let qcom,qcs615-venus fallback to qcom,sc7180-venus on QCS615 platform. Signed-off-by: Renjiang Han <quic_renjiang@quicinc.com> --- Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)